php/web-gcov
1
0
Fork 0
mirror of https://github.com/php/web-gcov.git synced 2026-03-24 17:22:18 +01:00
Code Issues 11 Packages Projects Releases Wiki Activity

[PR #4] [CLOSED] Remove unneeded vcsclean script call #2

New Issue
Closed
opened 2026-01-24 11:41:24 +01:00 by admin · 0 comments
admin commented 2026-01-24 11:41:24 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/php/web-gcov/pull/4
Author: @petk
Created: 2/12/2019
Status: ❌ Closed

Base: master ← Head: patch-vcsclean

📝 Commits (1)

  • 86283f1 Remove unneeded vcsclean script call

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 cron/cron.sh (+0 -1)

📄 Description

The vcsclean shell script from the php-src repository is a simple wrapper
around the command of git -Xfd and is in the process of being moved from
the root location in the php-src repository in newer PHP branches to a more
dedicated place inside the scripts directory.

This particular call here is even not necessary because there is a
git clean call done one line below after it.

cc @nikic
discussion: https://github.com/php/php-src/pull/3589

Thank you.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/php/web-gcov/pull/4 **Author:** [@petk](https://github.com/petk) **Created:** 2/12/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-vcsclean` --- ### 📝 Commits (1) - [`86283f1`](https://github.com/php/web-gcov/commit/86283f161dd79ce40b4f092bb84372ec17c239a8) Remove unneeded vcsclean script call ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cron/cron.sh` (+0 -1) </details> ### 📄 Description The `vcsclean` shell script from the php-src repository is a simple wrapper around the command of `git -Xfd` and is in the process of being moved from the root location in the php-src repository in newer PHP branches to a more dedicated place inside the scripts directory. This particular call here is even not necessary because there is a git clean call done one line below after it. cc @nikic discussion: https://github.com/php/php-src/pull/3589 Thank you. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-24 11:41:24 +01:00
admin closed this issue 2026-01-24 11:41:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: php/web-gcov#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?