[PR #10] [CLOSED] Fix tests for 7.4 and up, drop 7.3 and under #14

New Issue

admin · 2026-01-24T11:41:25+01:00

admin commented

2026-01-24 11:41:25 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/web-gcov/pull/10
Author: @pcrov
Created: 12/3/2020
Status: ❌ Closed

Base: master ← Head: fixbuilds

📝 Commits (1)

861780f Fix build for 7.4 and up, drop 7.3 and under

📊 Changes

2 files changed (+2 additions, -4 deletions)

View changed files

📝 cron/cron.sh (+1 -1)
📝 cron/tags.inc (+1 -3)

📄 Description

Somewhere in the 7.4 cycle the lcov make target ditched its dependency on test, so this should fix generating coverage data. It'd break for 7.3 and earlier but I don't think they're worth the extra work to support so they're removed.

I've been told gcov.php.net has been decommissioned, but it's still up right now and may as well work until it's gone. Who knows, the replacement might turn out to be a dud and gcov kept after all.

Small caveat: I didn't set up a replica of web-gcov to test this as that seemed like significant under-documented pain. Keep your fingers crossed 🤞.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/web-gcov/pull/10 **Author:** [@pcrov](https://github.com/pcrov) **Created:** 12/3/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fixbuilds` --- ### 📝 Commits (1) - [`861780f`](https://github.com/php/web-gcov/commit/861780fb08e57d3509450ccb16f0ee9866e7efad) Fix build for 7.4 and up, drop 7.3 and under ### 📊 Changes **2 files changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `cron/cron.sh` (+1 -1) 📝 `cron/tags.inc` (+1 -3) </details> ### 📄 Description Somewhere in the 7.4 cycle the lcov make target ditched its dependency on test, so this should fix generating coverage data. It'd break for 7.3 and earlier but I don't think they're worth the extra work to support so they're removed. I've been told gcov.php.net has been decommissioned, but it's still up right now and may as well work until it's gone. Who knows, the replacement might turn out to be a dud and gcov kept after all. Small caveat: I didn't set up a replica of web-gcov to test this as that seemed like significant under-documented pain. Keep your fingers crossed 🤞. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:41:25 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/web-gcov#14