mirror of
https://github.com/php/web-doc-editor.git
synced 2026-03-24 17:22:08 +01:00
This patch adds some missing newlines and trims multiple final newlines into a single newline. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
50 lines
1.5 KiB
JavaScript
50 lines
1.5 KiB
JavaScript
Ext.namespace('ui','ui.task');
|
|
|
|
// config - { patchID, patchName, nodesToAdd }
|
|
ui.task.MoveToPatch = function(config)
|
|
{
|
|
Ext.apply(this, config);
|
|
|
|
var filesID=[];
|
|
|
|
Ext.each(this.nodesToAdd, function(node) {
|
|
filesID.push(node.attributes.idDB);
|
|
});
|
|
|
|
Ext.getBody().mask(
|
|
'<img src="themes/img/loading.gif" style="vertical-align: middle;" /> ' +
|
|
_('Please, wait...')
|
|
);
|
|
|
|
XHR({
|
|
scope : this,
|
|
params : {
|
|
task : 'moveToPatch',
|
|
patchID : this.patchID,
|
|
filesID : filesID.join(',')
|
|
},
|
|
success : function()
|
|
{
|
|
Ext.getBody().unmask();
|
|
|
|
// We add this new patch, and nodesToAdd into Patches for review component
|
|
ui.cmp.PatchesTreeGrid.getInstance().addToPatch(this.patchID, this.patchName, this.nodesToAdd, this.patchDescription, this.patchEmail);
|
|
|
|
// We get all idDB from this nodes to delete record from Work in progress
|
|
if( this.nodesToAdd ) {
|
|
Ext.each(this.nodesToAdd, function(node) {
|
|
ui.cmp.WorkTreeGrid.getInstance().delRecord(node.attributes.idDB);
|
|
});
|
|
}
|
|
|
|
},
|
|
failure : function(r)
|
|
{
|
|
var o = Ext.util.JSON.decode(r.responseText);
|
|
Ext.getBody().unmask();
|
|
|
|
Ext.MessageBox.alert(_('Error'), _(o.err));
|
|
}
|
|
});
|
|
};
|