23 Commits

Author SHA1 Message Date
Peter Kokot
f06fee3640 Sync final newlines
This patch adds some missing newlines and trims multiple final newlines
into a single newline.

According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
2018-10-02 03:44:40 +02:00
Peter Kokot
9895f91d46 Trim trailing whitespace 2018-10-02 03:21:09 +02:00
Nico Oelgart
732de5780d Fix grammar 2018-10-02 00:40:43 +02:00
Yannick Torrès
5d1bdb1196 Add a new method to handle a global update 2013-07-17 19:29:24 +02:00
Yannick Torres
25929b8508 On ping failure, we now display a more discreet non intrusive window. No more button, just a timer of 30 seconds to try again 2011-11-16 21:33:01 +00:00
Yannick Torres
329043bfba Handle a ping failure and display an error message insted of reload directly the application 2011-11-16 18:59:49 +00:00
Yannick Torres
e632d94c9a Update the topic if necessary using the ping processus 2011-07-04 06:42:12 +00:00
Yannick Torres
8894d203d9 CleanUp the code 2011-01-02 02:15:59 +00:00
Yannick Torres
e232ed22e7 New :
* upgrade extJs to 3.2.1
* Remove "Pending commit" module in favore to "work in progress" module
* Remove "Pending patch" module in favore to "patches for review" module
* Add a field to ask for an email when we logging in. It allow users to contact others.
* Add a progress bar to allow user indicate the progression of his work
* Anonymous user are no longer "anonymous", as a cookie is set on connexion to "authenticate" him.
* Anonymous user can save a file as an authenticated user. No longer only use the "patch" button.
* New rules when a file is edited. When the file is edited by :

  - an anonymous user : authenticated user can always edit it. When he does, the owner change and anonymous user can't edit it again.

  - an authenticated user : anonymous and others authenticated users can't edit it. The first user must release it (eithers commit his change, or remove the change he does). Administrator can edit it. This can allow to override change made by an authenticated user. Administrators are defined per project in configuration file.

* We no longer allow a user to commit files changed by others users. An authenticated user can only commit his files.

Bugs :

  - fix bug #51767
  - fix bug that display internal file (.new) in some modules
  - change file() class beaviours
2010-05-24 20:04:32 +00:00
Yannick Torres
f0cac3ec63 Simplify the store ; remove unecessary arguments in some functions ; reindent ; move js/ui/component/ to js/ui/cmp/ to save some space 2010-04-25 15:39:34 +00:00
Yannick Torres
7fa3829f2f On pingTask, we now detect if there is a new Info and reload the PortletInfo if so 2010-04-12 17:39:01 +00:00
Yannick Torres
bed4f7a1b4 Remove updateData & checkEntities from ping processus 2010-03-28 20:02:16 +00:00
Yannick Torres
b1b4288752 Fix bug when pingTask return false, e.g. the user session don't exist anymore 2010-03-12 20:41:32 +00:00
Yannick Torres
08f3a48f62 CleanUp code 2010-03-11 10:27:39 +00:00
Yannick Torres
9ca16323e7 Change the name of the class to reflect the new name of this app 2010-03-02 12:29:21 +00:00
Yannick Torres
8e5a352f1f Add multi-project support into the editor. 2010-01-04 00:15:20 +00:00
Yannick Torres
d97d2ab20e Don't check anythings on ping with EN language & reload Summary if needed when data change 2010-01-01 14:01:07 +00:00
Yannick Torres
5e6ce97cf0 On ping(), we search if there is some modification in differents modules. If so, we reload it to reflect the change 2009-12-30 23:55:20 +00:00
Yannick Torres
cdbd408dbc exec jsLint on ui/task 2009-10-24 09:04:41 +00:00
Chan Ka Shing
f7bd0a3d1b modification/fix:
* adopted mod_rewrite, reflect changes to URLs
  * util.js - XHR will now always fire requset to server with mod_rewrite defined rule
  * login.js - reformat codes, cvs2svn adoption changes
2009-08-12 07:17:22 +00:00
Chan Ka Shing
ec7a55c1aa modification/fix:
* apply singleton pattern to all unique component, singleton component can be obtained by ui.component.XXX.getInstance()
  * file panel exclude 'home' & 'end' key as modifying keys
  * file panel string concat using string.join() instead of operator +

main.js cleanup:
  * migrated phpDoc.saveLangFile into ui/component/FilePanel.js
  * migrated repositoryContextMenu into ui/component/RepositoryTree.js
  * sendEmail is now wrapped in ui/component/EmailPrompt.js
  * WinCheckBuild is now wrapped in ui/component/CheckBuildPrompt and ui/task/CheckBuildTask.js
  * WinUpdate is now wrapped in ui/component/SystemUpdatePrompt and ui/task/SystemUpdateTask
  * WinCommit is now wrapped in ui/component/CommitPrompt and ui/task/CVSCommitTask.js;
    CommitLog management is now in ui/component/CommitLogPrompt
2009-07-03 04:11:10 +00:00
Chan Ka Shing
fdab95a628 modification/fix:
* fix CodeMirror cannot display the end of vertical scroll [bug in last commit]
  * FilePendingOpen queue is now storing { fpath, fname } object instead of plain array
  * created static reference for singleton components, dependency on phpDoc.xxx are removed and use ui.component.xxx.instance instead
  * created static reference for PingTask, dependency on phpDoc.TaskPing is removed
  * remove .run() in task/*.js
  * fix openning multiple files will stop when some files already opened

main.js cleanup:
  * load configuration task is wrapped in ui/task/LoadConfigTask.js
  * menuMarkupEN & menuMarkupLANG is now wrapped in ui/component/FilePanel.js
  * newTabCheckDoc, newTabBuildStatus, winConf, winAbout is now wrapped in ui/component/MainMenu.js
  * getFile is now wrapped in ui/task/GetFileTask.js
  * confUpdate is now wrapped in ui/task/UpdateConfTask.js
  * winDiff moved into CVSLogGrid.js
  * newTabMailing moved into LocalMailGrid.js
  * newTabBugs moved into BugsGrid.js
  * addToPendingPatch is now wrapped in ui/task/SavePatchTask.js
  * addToPeningCommit moved into PendingCommitGrid.js
2009-06-26 10:29:45 +00:00
Chan Ka Shing
589c2c87f5 modification/fix:
* TODO update
    - [Bug report] ClearLocalChange in class.php would attempt to remove a unexisting file thus gives invalid json response
    - added 3 items for follow-up actions of this commit
  * reloacate PingTask from js/ui to js/ui/task
  * yui-compression script included js/ui/task/*.js
  * util.log is allowed to accept arbitrary length of argments
  * fix invalid argment passing in Ext.ux.CodeMirror initialize event
  * js/ui/component/CheckDoc renames config-args
  * fix "Refresh All Data" and "Check Build" failure due to http-timeout (bug of XHR abstraction.. pending decision of keeping XHR)

main.js cleanup:
  * FilesNeedUpdateGrid is now wrapped in ui/component/StaleFileGrid.js
    - staleFileGrid handle introduced to phpDoc-namespace
  * TreeAllFile is now wrapped in ui/component/RepositoryTree.js
  * vc-diff panel is now wrapped in ui/component/ViewVCDiff.js
  * exec-diff panel is now wrapped in ui/component/ExecDiff.js
  * main-menu is now wrapped in ui/component/MainMenu.js
  * save-patch prompt is now wrapped in ui/component/PatchPrompt.js

  * Introduced _saveEnFile, _saveLangFile, _savePatch for refactored FilesNeedUpdateGrid/TreeAllFiles
    - for backward compatibility, saveEnFile, saveLangFile, savePatch remain in main.js
    - check file when save is now wrapped in ui/task/CheckFileTask.js
    - save en file is now wrapped in ui/task/SaveENFileTask.js
    - save lang file is now wrapped in ui/task/SaveLangFile.js
    - will merge save en/lang file sooner or later
  * Introduced repositoryContextMenu to phpDoc-namespace
    - will be relocated into ui/component/RepositoryTree.js sooner or later

  * Introduced reuseable CVSLogGrid component in ui/component/CVSLogGrid.js
  * Introduced reuseable FilePanel component in ui/component/FilePanel.js

  * Corresponding changes due to adoption of FilePanel
    - AF-tab remains AF-FileID, AF-panel and sub-components are now named AF-ALL-###-FileID
    - FNU-tab remains FNU-FileID, FNU-panel and sub-components are now either FNU-EN-###-FileID or FNU-LANG-###-FileID
    - relocate attributes (isModifiedEn & isModifiedLang) of FNU-tab to FNU-ENG-File-###.isModified and FNU-LANG-File-###.isModified
    - FilePanel alone is able to sync-scroll with anothor FilePanel via certain configuration
2009-06-15 07:04:54 +00:00