19 Commits

Author SHA1 Message Date
Peter Kokot f06fee3640 Sync final newlines
This patch adds some missing newlines and trims multiple final newlines
into a single newline.

According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
2018-10-02 03:44:40 +02:00
Peter Kokot 9895f91d46 Trim trailing whitespace 2018-10-02 03:21:09 +02:00
Yannick Torres c581640b28 Add a window validation when a VCS user open a modified file by an anonymous user from patches for review module 2011-01-17 21:27:37 +00:00
Yannick Torres 8894d203d9 CleanUp the code 2011-01-02 02:15:59 +00:00
Yannick Torres e232ed22e7 New :
* upgrade extJs to 3.2.1
* Remove "Pending commit" module in favore to "work in progress" module
* Remove "Pending patch" module in favore to "patches for review" module
* Add a field to ask for an email when we logging in. It allow users to contact others.
* Add a progress bar to allow user indicate the progression of his work
* Anonymous user are no longer "anonymous", as a cookie is set on connexion to "authenticate" him.
* Anonymous user can save a file as an authenticated user. No longer only use the "patch" button.
* New rules when a file is edited. When the file is edited by :

  - an anonymous user : authenticated user can always edit it. When he does, the owner change and anonymous user can't edit it again.

  - an authenticated user : anonymous and others authenticated users can't edit it. The first user must release it (eithers commit his change, or remove the change he does). Administrator can edit it. This can allow to override change made by an authenticated user. Administrators are defined per project in configuration file.

* We no longer allow a user to commit files changed by others users. An authenticated user can only commit his files.

Bugs :

  - fix bug #51767
  - fix bug that display internal file (.new) in some modules
  - change file() class beaviours
2010-05-24 20:04:32 +00:00
Yannick Torres f0cac3ec63 Simplify the store ; remove unecessary arguments in some functions ; reindent ; move js/ui/component/ to js/ui/cmp/ to save some space 2010-04-25 15:39:34 +00:00
Yannick Torres 7569038c51 Fix bug in clearLocalChange 2010-04-03 11:03:21 +00:00
Yannick Torres 4235f8973f check errors file to remove red mark 2010-03-22 21:47:28 +00:00
Yannick Torres df13702264 Review the clear local change action : now, when a file is open, it is close when you accept to clear the local change ; if a file in 'need translate' have been modified, the clear local change will clear the red flag too 2010-03-19 06:44:25 +00:00
Yannick Torres 77a48939de cleanUp the code 2010-03-13 16:38:22 +00:00
Yannick Torres 08f3a48f62 CleanUp code 2010-03-11 10:27:39 +00:00
Yannick Torres 9ca16323e7 Change the name of the class to reflect the new name of this app 2010-03-02 12:29:21 +00:00
Yannick Torres e8ad333515 Solve some bugs with clearLocalChange 2009-11-22 18:18:02 +00:00
Yannick Torres 7a34db02e7 Allow anonymous connection with no login & no password, or by providing 'anonymous' as login with no password. By default, add 'anonymous' value into login's form 2009-11-16 18:50:45 +00:00
Yannick Torres cdbd408dbc exec jsLint on ui/task 2009-10-24 09:04:41 +00:00
Chan Ka Shing f7bd0a3d1b modification/fix:
* adopted mod_rewrite, reflect changes to URLs
  * util.js - XHR will now always fire requset to server with mod_rewrite defined rule
  * login.js - reformat codes, cvs2svn adoption changes
2009-08-12 07:17:22 +00:00
Chan Ka Shing ec7a55c1aa modification/fix:
* apply singleton pattern to all unique component, singleton component can be obtained by ui.component.XXX.getInstance()
  * file panel exclude 'home' & 'end' key as modifying keys
  * file panel string concat using string.join() instead of operator +

main.js cleanup:
  * migrated phpDoc.saveLangFile into ui/component/FilePanel.js
  * migrated repositoryContextMenu into ui/component/RepositoryTree.js
  * sendEmail is now wrapped in ui/component/EmailPrompt.js
  * WinCheckBuild is now wrapped in ui/component/CheckBuildPrompt and ui/task/CheckBuildTask.js
  * WinUpdate is now wrapped in ui/component/SystemUpdatePrompt and ui/task/SystemUpdateTask
  * WinCommit is now wrapped in ui/component/CommitPrompt and ui/task/CVSCommitTask.js;
    CommitLog management is now in ui/component/CommitLogPrompt
2009-07-03 04:11:10 +00:00
Chan Ka Shing fdab95a628 modification/fix:
* fix CodeMirror cannot display the end of vertical scroll [bug in last commit]
  * FilePendingOpen queue is now storing { fpath, fname } object instead of plain array
  * created static reference for singleton components, dependency on phpDoc.xxx are removed and use ui.component.xxx.instance instead
  * created static reference for PingTask, dependency on phpDoc.TaskPing is removed
  * remove .run() in task/*.js
  * fix openning multiple files will stop when some files already opened

main.js cleanup:
  * load configuration task is wrapped in ui/task/LoadConfigTask.js
  * menuMarkupEN & menuMarkupLANG is now wrapped in ui/component/FilePanel.js
  * newTabCheckDoc, newTabBuildStatus, winConf, winAbout is now wrapped in ui/component/MainMenu.js
  * getFile is now wrapped in ui/task/GetFileTask.js
  * confUpdate is now wrapped in ui/task/UpdateConfTask.js
  * winDiff moved into CVSLogGrid.js
  * newTabMailing moved into LocalMailGrid.js
  * newTabBugs moved into BugsGrid.js
  * addToPendingPatch is now wrapped in ui/task/SavePatchTask.js
  * addToPeningCommit moved into PendingCommitGrid.js
2009-06-26 10:29:45 +00:00
Chan Ka Shing 8a64497643 modification/fix:
* fix ux.CodeMirror resize
    - file no longer need to fake resize after getFile
    - CodeMirror will auto-resize depends on TextArea height
  * removed dependency on _SaveEnFile after cleanup, for SaveEnFile logic see ui/task/SaveEnFileTask.js
  * removed dependency on _SavePatch after cleanup, for SavePatch logic see ui/component/SavePatchPrompt.js

main.js cleanup:
  * gridFilesError is now wrapped in ui/component/ErrorFileGrid.js
  * gridPendingPatch is now wrapped in ui/component/PendingPatchGrid.js
  * rejectPatch is now wrapped in ui/task/RejectPatchTask.js
  * saveFileViaPatch is now wrapped in ui/task/AcceptPatchTask.js
  * gridNotInEN is now wrapped in ui/component/NotInENGrid.js
  * mark-file-as-delete in non-en grid is now wrapped in ui/task/MarkDeleteTask.js
  * gridPendingCommit is now wrapped in ui/component/PendingCommitGrid.js
  * clearLocalChange is now wrapped in ui/task/ClearLocalChange.js
  * gridNeedReview is now wrapped in ui/component/PendingReviewGrid.js
2009-06-21 13:33:13 +00:00