1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00

Fix references in request_parse_body() options array

Otherwise we get funny messages like
"Invalid string value in $options argument".

Closes GH-14977.
This commit is contained in:
Niels Dossche
2024-07-16 18:06:06 +02:00
parent c4f1c5cd9f
commit f58a3c392f
3 changed files with 16 additions and 0 deletions

1
NEWS
View File

@@ -25,6 +25,7 @@ PHP NEWS
- Standard:
. Change highlight_string() and print_r() return type to string|true. (Ayesh)
. Fix references in request_parse_body() options array. (nielsdos)
- Windows:
. Update the icon of the Windows executables, e.g. php.exe. (Ayesh,

View File

@@ -244,6 +244,7 @@ static zend_result cache_request_parse_body_option(HashTable *options, zval *opt
{
if (option) {
zend_long result;
ZVAL_DEREF(option);
if (Z_TYPE_P(option) == IS_STRING) {
zend_string *errstr;
result = zend_ini_parse_quantity(Z_STR_P(option), &errstr);

View File

@@ -0,0 +1,14 @@
--TEST--
request_parse_body: reference in options array
--FILE--
<?php
$options = ['post_max_size' => '128M'];
foreach ($options as $k => &$v) {}
try {
request_parse_body($options);
} catch (Throwable $e) {
echo $e->getMessage(), "\n";
}
?>
--EXPECT--
Request does not provide a content type