php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.3'

Browse Source 
* PHP-8.3:
  Fix GH-14639: Member access within null pointer in ext/spl/spl_observer.c
This commit is contained in:
Niels Dossche
2024-07-06 23:58:37 +02:00
parent 776939c3db 8ea3f154be
commit e2189beaca
2 changed files with 29 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ext/spl/spl_observer.c
View File

@@ -115,9 +115,11 @@ static void spl_object_storage_free_hash(spl_SplObjectStorage *intern, zend_hash
static void spl_object_storage_dtor(zval *element) /* {{{ */
{
spl_SplObjectStorageElement *el = Z_PTR_P(element);
zend_object_release(el->obj);
zval_ptr_dtor(&el->inf);
efree(el);
if (el) {
zend_object_release(el->obj);
zval_ptr_dtor(&el->inf);
efree(el);
}
} /* }}} */
static spl_SplObjectStorageElement* spl_object_storage_get(spl_SplObjectStorage *intern, zend_hash_key *key) /* {{{ */
@@ -165,8 +167,10 @@ static spl_SplObjectStorageElement *spl_object_storage_attach_handle(spl_SplObje
return pelement;
}
/* NULL initialization necessary because `spl_object_storage_create_element` could bail out due to OOM. */
ZVAL_PTR(entry_zv, NULL);
pelement = spl_object_storage_create_element(obj, inf);
ZVAL_PTR(entry_zv, pelement);
Z_PTR_P(entry_zv) = pelement;
return pelement;
} /* }}} */

21
ext/spl/tests/gh14639.phpt Normal file
View File

@@ -0,0 +1,21 @@
--TEST--
GH-14639 (Member access within null pointer in ext/spl/spl_observer.c)
--INI--
memory_limit=2M
--SKIPIF--
<?php
if (getenv("USE_ZEND_ALLOC") === "0") {
die("skip Zend MM disabled");
}
?>
--FILE--
<?php
$b = new SplObjectStorage();
for ($i = 10000; $i > 0; $i--) {
$object = new StdClass();
$object->a = str_repeat("a", 2);
$b->attach($object);
}
?>
--EXPECTF--
Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d