php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid making a redundant copy in php_filter_callback() (#18794)

Browse Source 
`call_user_function` already makes a copy to the call frame for its
arguments, there's no need to do this ourselves.
This commit is contained in:
Niels Dossche
2025-06-08 11:23:31 +02:00
committed by GitHub
parent ceffa70b97
commit cb04226b4a
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ext/filter/callback_filter.c
View File

@@ -19,7 +19,6 @@
void php_filter_callback(PHP_INPUT_FILTER_PARAM_DECL)
{
zval retval;
zval args[1];
int status;
if (!option_array || !zend_is_callable(option_array, IS_CALLABLE_SUPPRESS_DEPRECATIONS, NULL)) {
@@ -29,8 +28,7 @@ void php_filter_callback(PHP_INPUT_FILTER_PARAM_DECL)
return;
}
ZVAL_COPY(&args[0], value);
status = call_user_function(NULL, NULL, option_array, &retval, 1, args);
status = call_user_function(NULL, NULL, option_array, &retval, 1, value);
if (status == SUCCESS && !Z_ISUNDEF(retval)) {
zval_ptr_dtor(value);
@@ -39,6 +37,4 @@ void php_filter_callback(PHP_INPUT_FILTER_PARAM_DECL)
zval_ptr_dtor(value);
ZVAL_NULL(value);
}
zval_ptr_dtor(&args[0]);
}