php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 08:12:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Output blocks of safe chars in php_filter_encode_html()

Browse Source 
Fixes a long-standing TODO, and is faster.
This commit is contained in:
Niels Dossche
2025-06-07 14:28:44 +02:00
parent 31b4f39d3e
commit c02f6fb3fe
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ext/filter/sanitizing_filters.c
View File

@@ -31,6 +31,7 @@ static void php_filter_encode_html(zval *value, const unsigned char *chars)
size_t len = Z_STRLEN_P(value);
unsigned char *s = (unsigned char *)Z_STRVAL_P(value);
unsigned char *e = s + len;
unsigned char *last_output = s;
if (Z_STRLEN_P(value) == 0) {
return;
@@ -38,16 +39,17 @@ static void php_filter_encode_html(zval *value, const unsigned char *chars)
while (s < e) {
if (chars[*s]) {
smart_str_appendl(&str, (const char *) last_output, s - last_output);
smart_str_appendl(&str, "&#", 2);
smart_str_append_unsigned(&str, (zend_ulong)*s);
smart_str_appendc(&str, ';');
} else {
/* XXX: this needs to be optimized to work with blocks of 'safe' chars */
smart_str_appendc(&str, *s);
last_output = s + 1;
}
s++;
}
smart_str_appendl(&str, (const char *) last_output, s - last_output);
zval_ptr_dtor(value);
ZVAL_NEW_STR(value, smart_str_extract(&str));
}