php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

abs: Make value == ZEND_LONG_MIN an unexpected branch

Browse Source 
As suggested in GH-12286. This results in slightly better assembly in clang,
because the expected case will be handled by a forward jump that is not taken.
This commit is contained in:
Tim Düsterhus
2023-09-24 17:20:23 +02:00
parent 865535267b
commit 9e66bc9b97
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ext/standard/math.c
View File

@@ -260,7 +260,7 @@ PHP_FUNCTION(abs)
switch (Z_TYPE_P(value)) {
case IS_LONG:
if (Z_LVAL_P(value) == ZEND_LONG_MIN) {
if (UNEXPECTED(Z_LVAL_P(value) == ZEND_LONG_MIN)) {
RETURN_DOUBLE(-(double)ZEND_LONG_MIN);
} else {
RETURN_LONG(Z_LVAL_P(value) < 0 ? -Z_LVAL_P(value) : Z_LVAL_P(value));