php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Mark Phar::buildFromIterator() base directory argument as a path

Browse Source 
This is like buildFromDirectory() which does it right.

Closes GH-20892.
This commit is contained in:
Niels Dossche
2026-01-10 10:52:28 +01:00
parent 2813f62476
commit 9ab800ec9b
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@@ -54,6 +54,8 @@ PHP NEWS
ignored. (ndossche)
. Support overridden methods in SplFileInfo for getMTime() and getPathname()
when building a phar. (ndossche)
. Mark Phar::buildFromIterator() base directory argument as a path.
(ndossche)
- Reflection:
. Fixed bug GH-20217 (ReflectionClass::isIterable() incorrectly returns true

2
ext/phar/phar_object.c
View File

@@ -1828,7 +1828,7 @@ PHP_METHOD(Phar, buildFromIterator)
zend_string *base = ZSTR_EMPTY_ALLOC();
struct _phar_t pass;
if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|S!", &obj, zend_ce_traversable, &base) == FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|P!", &obj, zend_ce_traversable, &base) == FAILURE) {
RETURN_THROWS();
}