mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
Merge branch 'PHP-8.4'
* PHP-8.4: ext/ldap: Fix GH-16101 (Segfaults in php_ldap_do_search() when LDAPs is not a list)
This commit is contained in:
@@ -1480,6 +1480,11 @@ static void php_ldap_do_search(INTERNAL_FUNCTION_PARAMETERS, int scope)
|
||||
ret = 0;
|
||||
goto cleanup;
|
||||
}
|
||||
if (!zend_array_is_list(Z_ARRVAL_P(link))) {
|
||||
zend_argument_value_error(1, "must be a list");
|
||||
ret = 0;
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
if (base_dn_ht) {
|
||||
nbases = zend_hash_num_elements(base_dn_ht);
|
||||
|
||||
25
ext/ldap/tests/gh16101.phpt
Normal file
25
ext/ldap/tests/gh16101.phpt
Normal file
@@ -0,0 +1,25 @@
|
||||
--TEST--
|
||||
Bug GH-16101: Segfault in ldap_list(), ldap_read(), and ldap_search() when LDAPs array is not a list
|
||||
--EXTENSIONS--
|
||||
ldap
|
||||
--FILE--
|
||||
<?php
|
||||
|
||||
/* We are assuming 3333 is not connectable */
|
||||
$ldap = ldap_connect('ldap://127.0.0.1:3333');
|
||||
$valid_dn = "cn=userA,something";
|
||||
$valid_filter = "";
|
||||
|
||||
$ldaps_dict = [
|
||||
"hello" => $ldap,
|
||||
"world" => $ldap,
|
||||
];
|
||||
try {
|
||||
var_dump(ldap_list($ldaps_dict, $valid_dn, $valid_filter));
|
||||
} catch (Throwable $e) {
|
||||
echo $e::class, ': ', $e->getMessage(), PHP_EOL;
|
||||
}
|
||||
|
||||
?>
|
||||
--EXPECT--
|
||||
ValueError: ldap_list(): Argument #1 ($ldap) must be a list
|
||||
Reference in New Issue
Block a user