php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

ext/pdo: Throw an exception instead of fatal error if the class is not found (#17528)

Browse Source
This commit is contained in:
Gina Peter Banyard
2025-01-19 23:35:24 +00:00
committed by GitHub
parent 9283abc1a0
commit 6bd2b8dfa5
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ext/pdo/pdo_stmt.c
View File

@@ -1231,7 +1231,7 @@ PHP_METHOD(PDOStatement, fetchAll)
zend_argument_type_error(2, "must be of type string, %s given", zend_zval_value_name(arg2));
RETURN_THROWS();
}
stmt->fetch.cls.ce = zend_fetch_class(Z_STR_P(arg2), ZEND_FETCH_CLASS_AUTO);
stmt->fetch.cls.ce = zend_lookup_class(Z_STR_P(arg2));
if (!stmt->fetch.cls.ce) {
zend_argument_type_error(2, "must be a valid class");
RETURN_THROWS();

5
ext/pdo/tests/pdo_stmt_class_ctor_errors_cannot_find_class.phpt
View File

@@ -39,7 +39,6 @@ require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
$db = PDOTest::factory();
PDOTest::dropTableIfExists($db, "pdo_fetch_all_class_error_unknown");
?>
--EXPECTF--
--EXPECT--
TypeError: PDOStatement::setFetchMode(): Argument #2 must be a valid class
Fatal error: Class "Unknown" not found in %s on line %d
TypeError: PDOStatement::fetchAll(): Argument #2 must be a valid class