php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

ext/standard/password: Use zend_string_efree() where possible (#19150)

Browse Source
This commit is contained in:
Niels Dossche
2025-07-17 18:51:49 +02:00
committed by GitHub
parent a8a3c81528
commit 56308f6490
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ext/standard/password.c
View File

@@ -86,18 +86,18 @@ static zend_string* php_password_make_salt(size_t length) /* {{{ */
buffer = zend_string_alloc(length * 3 / 4 + 1, 0);
if (FAILURE == php_random_bytes_throw(ZSTR_VAL(buffer), ZSTR_LEN(buffer))) {
zend_value_error("Unable to generate salt");
zend_string_release_ex(buffer, 0);
zend_string_efree(buffer);
return NULL;
}
ret = zend_string_alloc(length, 0);
if (php_password_salt_to64(ZSTR_VAL(buffer), ZSTR_LEN(buffer), length, ZSTR_VAL(ret)) == FAILURE) {
zend_value_error("Generated salt too short");
zend_string_release_ex(buffer, 0);
zend_string_release_ex(ret, 0);
zend_string_efree(buffer);
zend_string_efree(ret);
return NULL;
}
zend_string_release_ex(buffer, 0);
zend_string_efree(buffer);
ZSTR_VAL(ret)[length] = 0;
return ret;
}