php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.3'

Browse Source 
* PHP-8.3:
  Fix GH-13998: Manage refcount of agg_context->val correctly (#14004)
This commit is contained in:
Saki Takamachi
2024-04-20 22:34:53 +09:00
parent bca94e3420 43064160c4
commit 3e3875c379
2 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ext/pdo_sqlite/sqlite_driver.c
View File

@@ -426,7 +426,6 @@ static int do_callback(struct pdo_sqlite_fci *fc, zval *cb, int argc, sqlite3_va
* the context */
if (agg_context) {
if (Z_ISUNDEF(retval)) {
zval_ptr_dtor(&agg_context->val);
return FAILURE;
}
zval_ptr_dtor(Z_REFVAL(agg_context->val));

25
ext/pdo_sqlite/tests/gh13998.phpt Normal file
View File

@@ -0,0 +1,25 @@
--TEST--
Fix GH-13998: Manage refcount of agg_context->val correctly
--EXTENSIONS--
pdo_sqlite
--FILE--
<?php
$step = function () {
throw new Exception();
};
$finalize = function () {
};
$db = new PDO('sqlite::memory:');
$db->query('CREATE TABLE test (a int, b int)');
$stmt = $db->query('INSERT INTO test VALUES (1, 1), (2, 2), (3, 3)');
$db->sqliteCreateAggregate('S', $step, $finalize, 1);
try {
$db->query('SELECT S(a) FROM test');
} catch (Exception $e) {
echo 'done!';
}
?>
--EXPECT--
done!