php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-8.3'

Browse Source 
* PHP-8.3:
  jit: fixed JIT "Attempt to assign property of non-object" warning emitted at the same time as Error is being thrown
This commit is contained in:
Gina Peter Banyard
2023-11-27 16:21:01 +00:00
parent bd2c970e7e c70219e4aa
commit 298bba5319
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ext/opcache/jit/zend_jit_helpers.c
View File

@@ -1587,7 +1587,9 @@ static void ZEND_FASTCALL zend_jit_assign_dim_op_helper(zval *container, zval *d
}
zval_ptr_dtor(&res);
} else {
zend_error(E_WARNING, "Attempt to assign property of non-object");
/* Exception is thrown in this case */
GC_DELREF(obj);
return;
}
if (UNEXPECTED(GC_DELREF(obj) == 0)) {
zend_objects_store_del(obj);

19
ext/opcache/tests/jit/gh12723-B.phpt Normal file
View File

@@ -0,0 +1,19 @@
--TEST--
GH-12723: JIT emits "Attempt to assign property of non-object" warning at the same time as Error is being thrown
--INI--
opcache.enable=1
opcache.enable_cli=1
--FILE--
<?php
$container = new stdClass();
try {
$container[new stdClass()] .= 'append';
} catch (\Throwable $e) {
echo $e->getMessage(), "\n";
}
?>
--EXPECT--
Cannot use object of type stdClass as array