php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use packed fill in scandir() (#20737)

Browse Source 
By preallocating the array to the right size and using a packed fill, we
can avoid reallocations and use the fastest way to fill the array.
This commit is contained in:
Niels Dossche
2025-12-21 13:30:20 -08:00
committed by GitHub
parent 9fffe41789
commit 1faf17b017
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ext/standard/dir.c
View File

@@ -558,11 +558,15 @@ PHP_FUNCTION(scandir)
RETURN_FALSE;
}
array_init(return_value);
array_init_size(return_value, n);
zend_hash_real_init_packed(Z_ARRVAL_P(return_value));
for (i = 0; i < n; i++) {
add_next_index_str(return_value, namelist[i]);
}
ZEND_HASH_FILL_PACKED(Z_ARRVAL_P(return_value)) {
for (i = 0; i < n; i++) {
ZEND_HASH_FILL_SET_STR(namelist[i]);
ZEND_HASH_FILL_NEXT();
}
} ZEND_HASH_FILL_END();
if (n) {
efree(namelist);