php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

xml: Drop unused XML_GetCurrentByteCount() compatibility wrapper (#20476)

Browse Source
This commit is contained in:
Niels Dossche
2025-11-14 18:23:13 +01:00
committed by GitHub
parent 9cd367362d
commit 11070509ae
3 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
UPGRADING.INTERNALS
View File

@@ -60,6 +60,8 @@ PHP 8.6 INTERNALS UPGRADE NOTES
- ext/xml:
. Removed the XML_ExpatVersion() libxml compatibility wrapper,
as it was unused.
. Removed the XML_GetCurrentByteCount() libxml compatibility wrapper,
as it was unused and could return the wrong result.
========================
4. OpCode changes

8
ext/xml/compat.c
View File

@@ -644,14 +644,6 @@ XML_GetCurrentByteIndex(XML_Parser parser)
(parser->parser->input->cur - parser->parser->input->base);
}
PHP_XML_API int
XML_GetCurrentByteCount(XML_Parser parser)
{
/* TODO: this is identical to ByteIndex; it should probably
* be different */
return (int) XML_GetCurrentByteIndex(parser);
}
PHP_XML_API void
XML_ParserFree(XML_Parser parser)
{

1
ext/xml/expat_compat.h
View File

@@ -147,7 +147,6 @@ PHP_XML_API const XML_Char *XML_ErrorString(int);
PHP_XML_API int XML_GetCurrentLineNumber(XML_Parser);
PHP_XML_API int XML_GetCurrentColumnNumber(XML_Parser);
PHP_XML_API long XML_GetCurrentByteIndex(XML_Parser);
PHP_XML_API int XML_GetCurrentByteCount(XML_Parser);
PHP_XML_API void XML_ParserFree(XML_Parser);
#elif defined(HAVE_LIBEXPAT)