php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update DOM test to work around libxml2 bug

Browse Source 
As reported in GH-12024, the test fails in the encoding part of the test
file. This is due to a libxml2 bug (that's been fixed in modern
versions, but of course various systems and distros are always behind).
The goal of this part of the test is to check if an encoding declaration
is outputted. So the actual encoding used doesn't matter.
Switch to UTF-8, which seems to always work, to work around the issue.
This commit is contained in:
Niels Dossche
2023-08-22 22:32:02 +02:00
parent 462792ee51
commit 0fd226c277
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ext/dom/tests/DOMDocument_saveXML_XML_SAVE_NO_DECL.phpt
View File

@@ -13,7 +13,8 @@ $doc->loadXML('<root>é</root>');
echo $doc->saveXML(options: 0);
echo $doc->saveXML(options: LIBXML_NOXMLDECL);
$doc->encoding = "BIG5";
// Explicit encoding test, to ensure no encoding declaration.
$doc->encoding = "UTF-8";
echo $doc->saveXML(options: LIBXML_NOXMLDECL);
// Edge case
@@ -24,5 +25,5 @@ var_dump($doc->saveXML(options: LIBXML_NOXMLDECL));
<?xml version="1.0"?>
<root>&#xE9;</root>
<root>&#xE9;</root>
<root>&#233;</root>
<root>é</root>
string(0) ""