[PR #7] [MERGED] Improved gtk_init error handling #11

New Issue

admin · 2026-01-24T11:41:02+01:00

admin commented

2026-01-24 11:41:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/php-gtk-src/pull/7
Author: @pocketpc
Created: 6/23/2014
Status: ✅ Merged
Merged: 6/24/2014
Merged by: @php-pulls

Base: master ← Head: master

📝 Commits (2)

4d8069b Improved gtk_init error handling
a6f4bb4 Normalize line endings for tests

📊 Changes

60 files changed (+1595 additions, -1590 deletions)

View changed files

➕ .gitattributes (+1 -0)
📝 ext/gtk+/php_gtk+.c (+6 -2)
📝 tests/GtkAboutDialog/activate-link-signal.phpt (+20 -20)
📝 tests/GtkCellView/get_cell_renderers-deprecated.phpt (+20 -20)
📝 tests/GtkInfoBar/__construct.phpt (+29 -29)
📝 tests/GtkLabel/get_current_uri.phpt (+21 -21)
📝 tests/GtkLabel/get_track_visited_links.phpt (+24 -24)
📝 tests/GtkLabel/set_track_visited_links.phpt (+28 -28)
📝 tests/GtkMenu/get_reserve_toggle_size.phpt (+24 -24)
📝 tests/GtkMenu/set_reserve_toggle_size.phpt (+28 -28)
📝 tests/GtkNotebook/get_group.phpt (+27 -27)
📝 tests/GtkNotebook/get_group_name.phpt (+24 -24)
📝 tests/GtkNotebook/group-name.phpt (+22 -22)
📝 tests/GtkNotebook/set_group.phpt (+50 -50)
📝 tests/GtkNotebook/set_group_name.phpt (+30 -30)
📝 tests/GtkPrintOperation/get_embed_page_setup.phpt (+24 -24)
📝 tests/GtkPrintOperation/get_has_selection.phpt (+24 -24)
📝 tests/GtkPrintOperation/get_n_pages_to_print.phpt (+21 -21)
📝 tests/GtkPrintOperation/get_support_selection.phpt (+24 -24)
📝 tests/GtkPrintOperation/set_embed_page_setup.phpt (+28 -28)

...and 40 more files

📄 Description

Replaced gtk_init_check with gtk_init_with_args so that we can return
the actual GTK error if it fails instead of a generic error.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/php-gtk-src/pull/7 **Author:** [@pocketpc](https://github.com/pocketpc) **Created:** 6/23/2014 **Status:** ✅ Merged **Merged:** 6/24/2014 **Merged by:** [@php-pulls](https://github.com/php-pulls) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`4d8069b`](https://github.com/php/php-gtk-src/commit/4d8069ba86b23e0ece9086b735d1caad10906dc5) Improved gtk_init error handling - [`a6f4bb4`](https://github.com/php/php-gtk-src/commit/a6f4bb47ac9655724d92cd697b92f750f6b296df) Normalize line endings for tests ### 📊 Changes **60 files changed** (+1595 additions, -1590 deletions) <details> <summary>View changed files</summary> ➕ `.gitattributes` (+1 -0) 📝 `ext/gtk+/php_gtk+.c` (+6 -2) 📝 `tests/GtkAboutDialog/activate-link-signal.phpt` (+20 -20) 📝 `tests/GtkCellView/get_cell_renderers-deprecated.phpt` (+20 -20) 📝 `tests/GtkInfoBar/__construct.phpt` (+29 -29) 📝 `tests/GtkLabel/get_current_uri.phpt` (+21 -21) 📝 `tests/GtkLabel/get_track_visited_links.phpt` (+24 -24) 📝 `tests/GtkLabel/set_track_visited_links.phpt` (+28 -28) 📝 `tests/GtkMenu/get_reserve_toggle_size.phpt` (+24 -24) 📝 `tests/GtkMenu/set_reserve_toggle_size.phpt` (+28 -28) 📝 `tests/GtkNotebook/get_group.phpt` (+27 -27) 📝 `tests/GtkNotebook/get_group_name.phpt` (+24 -24) 📝 `tests/GtkNotebook/group-name.phpt` (+22 -22) 📝 `tests/GtkNotebook/set_group.phpt` (+50 -50) 📝 `tests/GtkNotebook/set_group_name.phpt` (+30 -30) 📝 `tests/GtkPrintOperation/get_embed_page_setup.phpt` (+24 -24) 📝 `tests/GtkPrintOperation/get_has_selection.phpt` (+24 -24) 📝 `tests/GtkPrintOperation/get_n_pages_to_print.phpt` (+21 -21) 📝 `tests/GtkPrintOperation/get_support_selection.phpt` (+24 -24) 📝 `tests/GtkPrintOperation/set_embed_page_setup.phpt` (+28 -28) _...and 40 more files_ </details> ### 📄 Description Replaced gtk_init_check with gtk_init_with_args so that we can return the actual GTK error if it fails instead of a generic error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:41:02 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/php-gtk-src#11