[PR #49] [CLOSED] Fixes #43: Modified what files get deleted #81

New Issue

admin · 2026-01-24T11:40:45+01:00

admin commented

2026-01-24 11:40:45 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/pftt2/pull/49
Author: @lavturo
Created: 6/25/2019
Status: ❌ Closed

Base: master ← Head: fix_issue43

📝 Commits (1)

d93dda0 Fixes #43: Removed EOL changes

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 src/com/mostc/pftt/model/core/PhptSourceTestPack.java (+6 -1)
📝 src/com/mostc/pftt/runner/AbstractPhptTestCaseRunner.java (+1 -0)

📄 Description

Updated following files to delete the temp SKIPIF files before a run starts and when a test succeeds. Also noticed that there were a few files left over from run-test.php, so added a few more extensions to be deleted before a run starts.

@weltling Could you check this? I'm actually not sure why it says I replaced the whole file when I only changed a few lines for PhptSourceTestPack.java. Changes I made were lines 142-151.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/pftt2/pull/49 **Author:** [@lavturo](https://github.com/lavturo) **Created:** 6/25/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_issue43` --- ### 📝 Commits (1) - [`d93dda0`](https://github.com/php/pftt2/commit/d93dda0a8bb6ea295b8421f9beb1dce7a2deafcc) Fixes #43: Removed EOL changes ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/com/mostc/pftt/model/core/PhptSourceTestPack.java` (+6 -1) 📝 `src/com/mostc/pftt/runner/AbstractPhptTestCaseRunner.java` (+1 -0) </details> ### 📄 Description Updated following files to delete the temp SKIPIF files before a run starts and when a test succeeds. Also noticed that there were a few files left over from run-test.php, so added a few more extensions to be deleted before a run starts. @weltling Could you check this? I'm actually not sure why it says I replaced the whole file when I only changed a few lines for `PhptSourceTestPack.java`. Changes I made were lines 142-151. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:40:45 +01:00

admin closed this issue

2026-01-24 11:40:45 +01:00

admin referenced this issue

2026-01-24 11:40:49 +01:00

[PR #82] [CLOSED] Fix #81: Lower-casing of PHPT file names can break tests #104

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/pftt2#81