[PR #34] [CLOSED] Fixes #33 #75

New Issue

admin · 2026-01-24T11:40:43+01:00

admin commented

2026-01-24 11:40:43 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/pftt2/pull/34
Author: @lavturo
Created: 5/28/2019
Status: ❌ Closed

Base: master ← Head: fix_issue33

📝 Commits (1)

f1af7f2 Fixes [test issue] PHP Fatal error calling opcache functinos (#33)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 bin/pftt2_release.cmd (+1 -1)

📄 Description

@weltling This is a very small change, but it seems that when we SET PFTT_RELEASE = %PFTT_HOME%\pftt_release in the middle of the code instead of at the beginning, it doesn't set it right away. Since it isn't set right away, it refers to \bin instead of %PFTT_RELEASE%\bin.

This will make the script pack an empty dir instead of the required directories to make pftt run with minimal files.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/pftt2/pull/34 **Author:** [@lavturo](https://github.com/lavturo) **Created:** 5/28/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_issue33` --- ### 📝 Commits (1) - [`f1af7f2`](https://github.com/php/pftt2/commit/f1af7f25e29ae4276e309908a2cc2bb1ce4b510e) Fixes #33 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `bin/pftt2_release.cmd` (+1 -1) </details> ### 📄 Description @weltling This is a very small change, but it seems that when we `SET PFTT_RELEASE = %PFTT_HOME%\pftt_release` in the middle of the code instead of at the beginning, it doesn't set it right away. Since it isn't set right away, it refers to `\bin` instead of `%PFTT_RELEASE%\bin`. This will make the script pack an empty dir instead of the required directories to make pftt run with minimal files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:40:43 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/pftt2#75