[PR #26] [CLOSED] Issue #4: Implement pftt setup, step 2 #69

New Issue

admin · 2026-01-24T11:40:42+01:00

admin commented

2026-01-24 11:40:42 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/pftt2/pull/26
Author: @lavturo
Created: 5/10/2019
Status: ❌ Closed

Base: master ← Head: fix_issue4

📝 Commits (8)

2f803fe Issue #4: Removed disabling firewall, implemented a way to let VCRedist and MySQL installer through firewall.
9258ec6 Issue #4: Updated for MySQL to install and setup properly.
0f42a11 Fixes Issue #4: Updated a portion for where files are stored and preventing same rules being added.
d231df0 Made method to add rules to firewall and updated sections to use this method.
f35c2d2 Removed unnecessary code, added comments and reduced redundent code.
942423e Added remoteip and swapped execElevated with execOut based on feedback.
48f5a31 Updated how to check if a rule already exists and removed unnecessary code.
8ee5d33 Added TODO for future reference and updated how to check for firewall rule.

📊 Changes

1 file changed (+37 additions, -19 deletions)

View changed files

📝 src/com/mostc/pftt/util/HostEnvUtil.java (+37 -19)

📄 Description

Removed disabling firewall, implemented a way to let VCRedist and MySQL installer through firewall.

@weltling I believe this works. I have yet to test it, but wanted to make sure this is the correct thing to do so far.

Edit: Tested MySQL and it was not being setup properly, but fixed it. If user is using this from command line, running command line with admin privileges would be recommended. Have to test VCRedist now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/pftt2/pull/26 **Author:** [@lavturo](https://github.com/lavturo) **Created:** 5/10/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_issue4` --- ### 📝 Commits (8) - [`2f803fe`](https://github.com/php/pftt2/commit/2f803fe7f9b35add5602a1690da27f104ff86387) Issue #4: Removed disabling firewall, implemented a way to let VCRedist and MySQL installer through firewall. - [`9258ec6`](https://github.com/php/pftt2/commit/9258ec6baa777bc6dc1d4822bcc6259ef8bee79e) Issue #4: Updated for MySQL to install and setup properly. - [`0f42a11`](https://github.com/php/pftt2/commit/0f42a1102c86efbeeda5fbc69ebe9fb313dce24b) Fixes Issue #4: Updated a portion for where files are stored and preventing same rules being added. - [`d231df0`](https://github.com/php/pftt2/commit/d231df0e02fcc0ef00166e41ddf0737d0bbfb68b) Made method to add rules to firewall and updated sections to use this method. - [`f35c2d2`](https://github.com/php/pftt2/commit/f35c2d2cf11d9b7951e3d993ce3f53a0322520ee) Removed unnecessary code, added comments and reduced redundent code. - [`942423e`](https://github.com/php/pftt2/commit/942423ef67c34c160a1995df509898b9ff387b56) Added remoteip and swapped execElevated with execOut based on feedback. - [`48f5a31`](https://github.com/php/pftt2/commit/48f5a31a4cbd4eb697ac1cc84afff1a0903cfaae) Updated how to check if a rule already exists and removed unnecessary code. - [`8ee5d33`](https://github.com/php/pftt2/commit/8ee5d331aa109afe0749b56b0f28a7cad36b9807) Added TODO for future reference and updated how to check for firewall rule. ### 📊 Changes **1 file changed** (+37 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/com/mostc/pftt/util/HostEnvUtil.java` (+37 -19) </details> ### 📄 Description Removed disabling firewall, implemented a way to let VCRedist and MySQL installer through firewall. @weltling I believe this works. I have yet to test it, but wanted to make sure this is the correct thing to do so far. Edit: Tested MySQL and it was not being setup properly, but fixed it. If user is using this from command line, running command line with admin privileges would be recommended. Have to test VCRedist now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:40:42 +01:00

admin referenced this issue

2026-01-24 11:40:48 +01:00

[PR #69] [CLOSED] Fixes #7: Replaced bundled source files with binaries #101

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/pftt2#69