php/pftt2
1
0
Fork 0
mirror of https://github.com/php/pftt2.git synced 2026-03-24 17:22:08 +01:00
Code Issues 46 Packages Projects Releases Wiki Activity

Check RANDOMLY_FAIL tests #39

New Issue
Open
opened 2026-01-24 11:40:25 +01:00 by admin · 1 comment
admin commented 2026-01-24 11:40:25 +01:00
Owner
Copy Link

Originally created by @cmb69 on GitHub (Jul 2, 2019).

There is a long list of PHPT files defined as RANDOMLY_FAIL. It seems that these tests are XSKIPped, which may no longer appropriate, so this list should be checked.

Originally created by @cmb69 on GitHub (Jul 2, 2019). There is a long list of PHPT files [defined as RANDOMLY_FAIL](https://github.com/php/pftt2/blob/master/src/com/mostc/pftt/scenario/CliScenario.java#L249-L320). It seems that these tests are XSKIPped, which may no longer appropriate, so this list should be checked.
admin added the enhancement label 2026-01-24 11:40:25 +01:00
admin commented 2026-01-24 11:40:25 +01:00
Author
Owner
Copy Link

@cmb69 commented on GitHub (Oct 14, 2019):

While having a closer look at this, I found SAPIScenario::RANDOMLY_FAIL which serves basically the same purpose, and is effectively inherited. Also there is CLIScenario::DISABLE_DEBUG_PROMPT which serves a similar purpose, and there may be more.

The goal should be to empty all these exclusion lists. If necessary, the test cases would have to be improved/fixed.

@cmb69 commented on GitHub (Oct 14, 2019): While having a closer look at this, I found [SAPIScenario::RANDOMLY_FAIL](https://github.com/php/pftt2/blob/8ef1c24a647d70c53a1f2d6b894e8d20f521e676/src/com/mostc/pftt/scenario/SAPIScenario.java#L145-L663) which serves basically the same purpose, and is effectively inherited. Also there is [CLIScenario::DISABLE_DEBUG_PROMPT](https://github.com/php/pftt2/blob/8ef1c24a647d70c53a1f2d6b894e8d20f521e676/src/com/mostc/pftt/scenario/CliScenario.java#L213-L248) which serves a similar purpose, and there may be more. The goal should be to empty all these exclusion lists. If necessary, the test cases would have to be improved/fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
invalid
pull-request
Mirrored from GitHub Pull Request
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: php/pftt2#39
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?