[PR #90] [CLOSED] Updated simplest app scenario (HelloWorld) #113

New Issue

admin · 2026-01-24T11:40:50+01:00

admin commented

2026-01-24 11:40:50 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/pftt2/pull/90
Author: @lavturo
Created: 12/20/2019
Status: ❌ Closed

Base: master ← Head: fix_issue5

📝 Commits (4)

a1f4294 Updated simplest app scenario (HelloWorld)
c594ef2 Updating phpunit
b1b0bfa Added HelloWorld test files and updated respective groovy file
db4b30d Updated to check for fileinfo extension

📊 Changes

599 files changed (+146 additions, -280938 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ bin/extractPhpUnit.php (+20 -0)
➕ cache/helloworld/tests/HelloWorld.php (+2 -0)
➕ cache/helloworld/tests/HelloWorldTest.php (+9 -0)
➖ cache/util/PEAR/data/PEAR/package.dtd (+0 -103)
➖ cache/util/PEAR/data/PEAR/template.spec (+0 -72)
➖ cache/util/PEAR/data/Structures_Graph/LICENSE (+0 -504)
➖ cache/util/PEAR/docs/Archive_Tar/docs/Archive_Tar.txt (+0 -461)
➖ cache/util/PEAR/docs/File_Iterator/ChangeLog.markdown (+0 -16)
➖ cache/util/PEAR/docs/File_Iterator/LICENSE (+0 -33)
➖ cache/util/PEAR/docs/File_Iterator/README.markdown (+0 -23)
➖ cache/util/PEAR/docs/PEAR/INSTALL (+0 -54)
➖ cache/util/PEAR/docs/PEAR/LICENSE (+0 -27)
➖ cache/util/PEAR/docs/PEAR/README (+0 -32)
➖ cache/util/PEAR/docs/PHPUnit/ChangeLog.markdown (+0 -121)
➖ cache/util/PEAR/docs/PHPUnit/LICENSE (+0 -33)
➖ cache/util/PEAR/docs/PHPUnit/README.markdown (+0 -81)
➖ cache/util/PEAR/docs/PHPUnit_MockObject/ChangeLog.markdown (+0 -19)
➖ cache/util/PEAR/docs/PHPUnit_MockObject/LICENSE (+0 -33)
➖ cache/util/PEAR/docs/PHP_CodeCoverage/ChangeLog.markdown (+0 -35)

...and 80 more files

📄 Description

@cmb69 @dalehhirt Please look over the changes. Overall, there are not too many big changes, just changes that were enough to get the HelloWorld scenario to work.

If you want specifics:

-CliPhpUnitTestCaseRunner.java was preventing pftt2 from running since it kept giving an error about php.ini not found.

-PhpUnitSourceTestPack.java had some issues finding some tests since pftt2 has all the paths with a forward-slash instead of back-slash.

-hello_world.groovy was implemented to run the simplest scenario. Kind of gives an idea of how other app scenarios should be structured (wordpress.groovy is probably a better one to reference)

-DOMDocument.php was giving an error regarding assertEquals function not being compatible with another assertEquals*. Updated for the time being. When/if we upgrade PHPUnit, this shouldn't be needed anymore. It is temporary for this function to work.

*Full error message

[Fatal error: Declaration of PHPUnit_Framework_Comparator_DOMDocument::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with PHPUnit_Framework_Comparator_Object::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in C:\pftt2\cache\util\PEAR\pear\PHPUnit\Framework\Comparator\DOMDocument.php on line 115]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/pftt2/pull/90 **Author:** [@lavturo](https://github.com/lavturo) **Created:** 12/20/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_issue5` --- ### 📝 Commits (4) - [`a1f4294`](https://github.com/php/pftt2/commit/a1f429434978c38166cd89070a5f6108a2d123db) Updated simplest app scenario (HelloWorld) - [`c594ef2`](https://github.com/php/pftt2/commit/c594ef290629b86c4387040df810f254e76505d1) Updating phpunit - [`b1b0bfa`](https://github.com/php/pftt2/commit/b1b0bfa3f32a00b765d37622008055116d76b5e5) Added HelloWorld test files and updated respective groovy file - [`db4b30d`](https://github.com/php/pftt2/commit/db4b30d9b97539ed873b05e3103cb30bce0b9b6f) Updated to check for fileinfo extension ### 📊 Changes **599 files changed** (+146 additions, -280938 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `bin/extractPhpUnit.php` (+20 -0) ➕ `cache/helloworld/tests/HelloWorld.php` (+2 -0) ➕ `cache/helloworld/tests/HelloWorldTest.php` (+9 -0) ➖ `cache/util/PEAR/data/PEAR/package.dtd` (+0 -103) ➖ `cache/util/PEAR/data/PEAR/template.spec` (+0 -72) ➖ `cache/util/PEAR/data/Structures_Graph/LICENSE` (+0 -504) ➖ `cache/util/PEAR/docs/Archive_Tar/docs/Archive_Tar.txt` (+0 -461) ➖ `cache/util/PEAR/docs/File_Iterator/ChangeLog.markdown` (+0 -16) ➖ `cache/util/PEAR/docs/File_Iterator/LICENSE` (+0 -33) ➖ `cache/util/PEAR/docs/File_Iterator/README.markdown` (+0 -23) ➖ `cache/util/PEAR/docs/PEAR/INSTALL` (+0 -54) ➖ `cache/util/PEAR/docs/PEAR/LICENSE` (+0 -27) ➖ `cache/util/PEAR/docs/PEAR/README` (+0 -32) ➖ `cache/util/PEAR/docs/PHPUnit/ChangeLog.markdown` (+0 -121) ➖ `cache/util/PEAR/docs/PHPUnit/LICENSE` (+0 -33) ➖ `cache/util/PEAR/docs/PHPUnit/README.markdown` (+0 -81) ➖ `cache/util/PEAR/docs/PHPUnit_MockObject/ChangeLog.markdown` (+0 -19) ➖ `cache/util/PEAR/docs/PHPUnit_MockObject/LICENSE` (+0 -33) ➖ `cache/util/PEAR/docs/PHP_CodeCoverage/ChangeLog.markdown` (+0 -35) _...and 80 more files_ </details> ### 📄 Description @cmb69 @dalehhirt Please look over the changes. Overall, there are not too many big changes, just changes that were enough to get the HelloWorld scenario to work. <details> <summary>If you want specifics:</summary> -`CliPhpUnitTestCaseRunner.java` was preventing pftt2 from running since it kept giving an error about php.ini not found. -`PhpUnitSourceTestPack.java` had some issues finding some tests since pftt2 has all the paths with a forward-slash instead of back-slash. -`hello_world.groovy` was implemented to run the simplest scenario. Kind of gives an idea of how other app scenarios should be structured (`wordpress.groovy` is probably a better one to reference) -`DOMDocument.php` was giving an error regarding assertEquals function not being compatible with another assertEquals*. Updated for the time being. When/if we upgrade PHPUnit, this shouldn't be needed anymore. **It is temporary for this function to work**. <details> <summary>*Full error message</summary> `[Fatal error: Declaration of PHPUnit_Framework_Comparator_DOMDocument::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with PHPUnit_Framework_Comparator_Object::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in C:\pftt2\cache\util\PEAR\pear\PHPUnit\Framework\Comparator\DOMDocument.php on line 115]` </details> </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:40:50 +01:00

admin closed this issue

2026-01-24 11:40:51 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/pftt2#113