[PR #73] [CLOSED] Putting more source files back #106

New Issue

admin · 2026-01-24T11:40:49+01:00

admin commented

2026-01-24 11:40:49 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/pftt2/pull/73
Author: @lavturo
Created: 9/20/2019
Status: ❌ Closed

Base: master ← Head: fix_issue71

📝 Commits (2)

552a473
47197a1 Merge branch 'master' into fix_issue71

📊 Changes

7 files changed (+2614 additions, -5 deletions)

View changed files

📝 .classpath (+0 -2)
📝 src/com/mostc/pftt/results/PhptTestResult.java (+2 -2)
📝 src/com/mostc/pftt/runner/AbstractPhptTestCaseRunner.java (+1 -1)
➕ src/org/incava/util/diff/Diff.java (+493 -0)
➕ src/org/incava/util/diff/Difference.java (+135 -0)
➕ src/org/kxml2/io/KXmlParser.java (+1436 -0)
➕ src/org/kxml2/io/KXmlSerializer.java (+547 -0)

📄 Description

@cmb69 So, after testing a bit more, it seems that there are NoClassDefFoundErrors with org.incava.diff.Diff and org.kxml2.io.KXmlParser when using pftt from cmd prompt.

Pftt won't run with the error occurring for KXmlParser but it seems that it can't catch failed tests with the error occurring with Diff. For the time being, it seems these have to be reverted as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/pftt2/pull/73 **Author:** [@lavturo](https://github.com/lavturo) **Created:** 9/20/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_issue71` --- ### 📝 Commits (2) - [`552a473`](https://github.com/php/pftt2/commit/552a473ec2e71055dc4e9e63955abea6d4fa1138) - [`47197a1`](https://github.com/php/pftt2/commit/47197a1a3eaf4d18a86cb3ad46a31496aa6d84c5) Merge branch 'master' into fix_issue71 ### 📊 Changes **7 files changed** (+2614 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.classpath` (+0 -2) 📝 `src/com/mostc/pftt/results/PhptTestResult.java` (+2 -2) 📝 `src/com/mostc/pftt/runner/AbstractPhptTestCaseRunner.java` (+1 -1) ➕ `src/org/incava/util/diff/Diff.java` (+493 -0) ➕ `src/org/incava/util/diff/Difference.java` (+135 -0) ➕ `src/org/kxml2/io/KXmlParser.java` (+1436 -0) ➕ `src/org/kxml2/io/KXmlSerializer.java` (+547 -0) </details> ### 📄 Description @cmb69 So, after testing a bit more, it seems that there are NoClassDefFoundErrors with `org.incava.diff.Diff` and `org.kxml2.io.KXmlParser` when using pftt from cmd prompt. Pftt won't run with the error occurring for `KXmlParser` but it seems that it can't catch failed tests with the error occurring with `Diff`. For the time being, it seems these have to be reverted as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:40:49 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/pftt2#106