php/pecl-search_engine-sphinx
1
0
Fork 0
mirror of https://github.com/php/pecl-search_engine-sphinx.git synced 2026-04-23 16:48:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

[PR #1] [MERGED] Segfault while calling updateAttributes #3

New Issue
Closed
opened 2026-01-24 11:39:57 +01:00 by admin · 0 comments
admin commented 2026-01-24 11:39:57 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/php/pecl-search_engine-sphinx/pull/1
Author: @deadbabe
Created: 3/23/2016
Status: ✅ Merged
Merged: 3/25/2016
Merged by: @php-pulls

Base: php7 ← Head: fix_get_key

📝 Commits (1)

📊 Changes

1 file changed (+19 additions, -34 deletions)

View changed files

📝 sphinx.c (+19 -34)

📄 Description

Last parameter (position) to zend_hash_get_current_key_ex require valid uint32 pointer and coulnd't be NULL. And since ZEND_HASH_FOREACH_* already used, it's might be better to completely drop using it. This fixes segfault while calling updateAttributes and some others.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/php/pecl-search_engine-sphinx/pull/1 **Author:** [@deadbabe](https://github.com/deadbabe) **Created:** 3/23/2016 **Status:** ✅ Merged **Merged:** 3/25/2016 **Merged by:** [@php-pulls](https://github.com/php-pulls) **Base:** `php7` ← **Head:** `fix_get_key` --- ### 📝 Commits (1) - [`9a3d08c`](https://github.com/php/pecl-search_engine-sphinx/commit/9a3d08c67af0cad216aa0d38d39be71362667738) fix updateAttributes ### 📊 Changes **1 file changed** (+19 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `sphinx.c` (+19 -34) </details> ### 📄 Description Last parameter (position) to zend_hash_get_current_key_ex require valid uint32 pointer and coulnd't be NULL. And since ZEND_HASH_FOREACH_\* already used, it's might be better to completely drop using it. This fixes segfault while calling updateAttributes and some others. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-24 11:39:57 +01:00
admin closed this issue 2026-01-24 11:39:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: php/pecl-search_engine-sphinx#3
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?