[PR #3] [MERGED] check for non-empty shortMsg #4

New Issue

admin · 2026-01-24T11:39:12+01:00

admin commented

2026-01-24 11:39:12 +01:00

📋 Pull Request Information

Original PR: https://github.com/php/karma/pull/3
Author: @salathe
Created: 1/14/2014
Status: ✅ Merged
Merged: 1/14/2014
Merged by: @php-pulls

Base: master ← Head: patch-1

📝 Commits (1)

3f2060b check for non-empty shortMsg

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 hooks/post-receive.bugsweb (+7 -5)

📄 Description

The $shortMsg value can be an empty string when the bug number is the last thing in the commit log line: e.g. "[user@php.net] 0df3233344 Fixed bug #1234"

This variable is not currently used anywhere, so we could probably remove it entirely. But for the moment, let's just fix the Notices being printed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/php/karma/pull/3 **Author:** [@salathe](https://github.com/salathe) **Created:** 1/14/2014 **Status:** ✅ Merged **Merged:** 1/14/2014 **Merged by:** [@php-pulls](https://github.com/php-pulls) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`3f2060b`](https://github.com/php/karma/commit/3f2060b2b660e7a002c82ede71ca2785bdb2280b) check for non-empty shortMsg ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `hooks/post-receive.bugsweb` (+7 -5) </details> ### 📄 Description The $shortMsg value can be an empty string when the bug number is the last thing in the commit log line: e.g. "[user@php.net] 0df3233344 Fixed bug #1234" This variable is not currently used anywhere, so we could probably remove it entirely. But for the moment, let's just fix the Notices being printed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:39:12 +01:00

admin closed this issue

2026-01-24 11:39:12 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: php/karma#4