This test was below (way below) the $URI = strtolower($URI) line, so
when browsing to /manual/pt_BR/function.strpos we were looking for
/manual/pt_br/function.strpos.php which doesn't exist (on case-sensitive
filesystems).
Note: This is a quick fix... if it causes (significant) issues, we might
have to think of a more involved solution than shuffling the code up the
file by a few hundred lines.
Remove reduntant/duplicate code between do-download and get-download
Also make this page more interesting when the download is missing from
this specific mirror by give the choise of going to other mirrors to check.
Rather then blindly go to the download file though we go to the same page
on the other mirror so we can check if the file exists there before giving
the link to the actual real file.
This also makes it a lot easier to work with on developers checkouts
Seems to fix couple of things, like actually including all the
supported" minor versions, not listing empty windows sections etc etc
probably breaks something too
welcome! A couple of important notes:
- I've largely dropped references to Subversion altogether, even knowing that
php-doc hasn't migrated yet. We may need to put a few more "Git/SVN account"
references in there if php-doc isn't going to be migrated in the near future.
- I've removed the quick start hints from git-php.php after an account request
has been sent in. The documentation there was pretty skimpy anyway and
probably wouldn't have been enough to get a developer going, plus it's harder
to distill the Git workflow into three or four snappy commands and I'm not
really convinced that a form confirmation page is the right place to have
learning materials, since it's a one-time page for most users. Instead I've
replaced them with links to the relevant Wiki pages, which seem more likely
to be the right place for new developers to learn.
News post to come, but I wanted to separate this out for easier review.
