Aside from being able to tell what color it is or what purpose it
solves just by looking at the variable name, it helps provide a
foundation for more easily changing the theme in the future.
Hopefully, we'll have a light and dark theme one day.
I've deliberately implemented this in such a way as to allow for further social
media buttons down the track if we want. I've also kept it intentionally
unobtrusive: it's there (previously, we only mentioned the Twitter account on
the mailing lists page, which was weird), but pretty subtle in the sidebar.
There's one additional dependency: a one glyph subset of Font Awesome (created
using Fontello) containing the Twitter icon. (Should we later want to include
other icons from Font Awesome, fonts/Font-Awesome/config.json can be fed back
into Fontello as a starting point.) The additional style sheet and font file
are cached correctly, and once loaded by the user, shouldn't need to be loaded
again, as with Fira Sans. On a cold page load, this adds two requests and just
under 3 kB to the page load.
I consider all of this reasonable, both technically and in terms of promoting
@official_php a little more, but I won't be terribly offended if someone wants
to revert this.
Some elements are sized relative to their parent (such as sub, sup); these were
left as em. Adjusted many line-heights, paddings and margins accordingly.
Also simplified some styles as a result.
After looking at our current website on 4 different monitors with
several different settings on each monitor, I concluded that we don't
have enough contrast in our website. This commit is primarily intended
to address this issue. Generally speaking, on mid to low grade monitors
I have considerably improved contrast and it looks pretty good. It does
not look as nice on the high-end monitors, though.
I am a horrible contributor who doesn't break my changes into multiple
commits so we get the spacing fixes this commit as well. I really do try
to do one 'feature' or change per commit, but I notice things that
bother me while fixing something else so I fix it...
