php/archived-web-php
1
0
Fork 0
mirror of https://github.com/php/web-php.git synced 2026-03-23 23:02:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only "linked" parameters should have pointer cursor (#742)

Browse Source 
If a parameter has no target to scroll to, it should not suggest
otherwise by changing the cursor to a pointer.  Since the scrolling is
done via JS, we should also change the cursor via JS.[1]

While we're at it, we also fix the potential JS error where we call the
`.offset()` method on an empty `jQuery` object.

[1] <https://github.com/php/doc-en/issues/2071#issuecomment-1354497367>
This commit is contained in:
Christoph M. Becker
2023-08-10 13:55:25 +02:00
committed by GitHub
parent 57fe66b12e
commit 8463593803
2 changed files with 23 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
js/common.js
View File

@@ -368,16 +368,29 @@ $(document).ready(function () {
$(this).append("<a class='genanchor' href='#" + $(this).parent().attr("id") + "'> ¶</a>");
});
$('.refentry code.parameter').click(function (event) {
var id = $(this).text().replace(/^&?(\.\.\.)?\$?/g, '');
var offsetTop = $('.parameters, .options').find('.parameter').filter(function () {
return $(this).text().trim() === id; // https://bugs.php.net/bug.php?id=74493
}).offset().top - 52;
$.scrollTo({
top: offsetTop,
left: 0
}, 400);
});
function findParameter(elt) {
var id = $(elt).text().replace(/^&?(\.\.\.)?\$?/g, '');
return $('.parameters, .options').find('.parameter').filter(function () {
return $(elt).text().trim() === id; // https://bugs.php.net/bug.php?id=74493
}).first();
}
$('.refentry code.parameter')
.each(function () {
var param = findParameter(this);
if (param.length) {
$(this).css('cursor', 'pointer');
}
})
.click(function () {
var param = findParameter(this);
if (param.length) {
$.scrollTo({
top: param.offset().top - 52,
left: 0
}, 400);
}
});
$('h1[id], h2[id], h3[id], h4[id]').each(function () {
var $this = $(this);