1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 16:22:37 +01:00
Files
Niels Dossche afb1c57470 Fix GH-14551: PGO build fails with xxhash
Turns out that the instrumentation added for gcov can change inlining
decisions of the compiler, which results in a mismatch between the
profile data CFG and the actual generated CFG between compiles.

There are two functions that suffer from this issue:
1. _PHP_XXH3_Init: Removing the inline hint fixes this one. In fact,
   always inlining this makes no sense as there's no real opportunity
   for specialising. It just bloats the binary and increases I$ pressure.
   So besides fixing this issue it's beneficial on its own to drop the
   attribute.
2. PHP_XXH3_128_Final: Sometimes XXH128_canonicalFromHash gets inlined
   and sometimes not. Make sure it gets always inlined.

Closes GH-18814.
2025-06-12 19:26:28 +02:00
..
2022-10-21 00:04:43 -06:00
2024-07-22 06:58:01 +02:00
2021-01-09 19:35:32 +01:00
2023-07-18 19:24:03 +02:00
2023-12-12 19:57:47 +01:00
2023-12-13 19:33:09 +01:00
2024-11-10 20:16:33 +00:00
2023-07-18 19:24:03 +02:00