mirror of
https://github.com/php/php-src.git
synced 2026-03-26 09:12:14 +01:00
0c238ede01
In other words, don't automatically unserialize when the magic phar:// stream wrappers are used. RFC: https://wiki.php.net/rfc/phar_stop_autoloading_metadata Also, change the signature from `getMetadata()` to `getMetadata(array $unserialize_options = [])`. Start throwing earlier if setMetadata() is called and serialization threw. See https://externals.io/message/110856 and https://bugs.php.net/bug.php?id=76774 This was refactored to add a phar_metadata_tracker for the following reasons: - The way to properly copy a zval was previously implicit and undocumented (e.g. is it a pointer to a raw string or an actual value) - Avoid unnecessary serialization and unserialization in the most common case - If a metadata value is serialized once while saving a new/modified phar file, this allows reusing the same serialized string. - Have as few ways to copy/clone/lazily parse metadata (etc.) as possible, so that code changes can be limited to only a few places in the future. - Performance is hopefully not a concern - copying a string should be faster than unserializing a value, and metadata should be rare in most cases. Remove unnecessary skip in a test(Compression's unused) Add additional assertions about usage of persistent phars Improve robustness of `Phar*->setMetadata()` - Add sanity checks for edge cases freeing metadata, when destructors or serializers modify the phar recursively. - Typical use cases of php have phar.readonly=1 and would not be affected. Closes GH-5855
40 lines
1.0 KiB
PHP
40 lines
1.0 KiB
PHP
--TEST--
|
|
Phar - bug #69720 - Null pointer dereference in phar_get_fp_offset()
|
|
--SKIPIF--
|
|
<?php if (!extension_loaded("phar")) die("skip"); ?>
|
|
--FILE--
|
|
<?php
|
|
try {
|
|
// open an existing phar
|
|
$p = new Phar(__DIR__."/bug69720.phar",0);
|
|
// Phar extends SPL's DirectoryIterator class
|
|
echo $p->getMetadata();
|
|
foreach (new RecursiveIteratorIterator($p) as $file) {
|
|
// $file is a PharFileInfo class, and inherits from SplFileInfo
|
|
$temp="";
|
|
$temp= $file->getFileName() . "\n";
|
|
$temp.=file_get_contents($file->getPathName()) . "\n"; // display contents
|
|
var_dump($file->getMetadata());
|
|
}
|
|
}
|
|
catch (Exception $e) {
|
|
echo 'Could not open Phar: ', $e;
|
|
}
|
|
?>
|
|
--EXPECTF--
|
|
MY_METADATA_NULL
|
|
|
|
Warning: file_get_contents(phar://%s): Failed to open stream: phar error: "test.php" is not a file in phar "%s.phar" in %s.php on line %d
|
|
array(1) {
|
|
["whatever"]=>
|
|
int(123)
|
|
}
|
|
object(DateTime)#6 (3) {
|
|
["date"]=>
|
|
string(26) "2000-01-01 00:00:00.000000"
|
|
["timezone_type"]=>
|
|
int(3)
|
|
["timezone"]=>
|
|
string(3) "UTC"
|
|
}
|