mirror of
https://github.com/php/php-src.git
synced 2026-04-27 01:48:26 +02:00
Nikita Popov
b10416a652
This deprecates passing null to non-nullable scale arguments of internal functions, with the eventual goal of making the behavior consistent with userland functions, where null is never accepted for non-nullable arguments. This change is expected to cause quite a lot of fallout. In most cases, calling code should be adjusted to avoid passing null. In some cases, PHP should be adjusted to make some function arguments nullable. I have already fixed a number of functions before landing this, but feel free to file a bug if you encounter a function that doesn't accept null, but probably should. (The rule of thumb for this to be applicable is that the function must have special behavior for 0 or "", which is distinct from the natural behavior of the parameter.) RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg Closes GH-6475.
37 lines
1.0 KiB
PHP
37 lines
1.0 KiB
PHP
--TEST--
|
|
Phar: Bug #77022: PharData always creates new files with mode 0666
|
|
--SKIPIF--
|
|
<?php
|
|
if (!extension_loaded("phar")) die("skip");
|
|
if (defined("PHP_WINDOWS_VERSION_MAJOR")) die("skip not for Windows")
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
umask(022);
|
|
var_dump(decoct(umask()));
|
|
|
|
$sFile = tempnam(__DIR__, 'test77022');
|
|
var_dump(decoct(stat($sFile)['mode']));
|
|
|
|
foreach([Phar::TAR => 'tar', Phar::ZIP => 'zip'] as $format => $ext) {
|
|
clearstatcache();
|
|
$phar = new PharData(__DIR__ . '/test77022.' . $ext, format: $format);
|
|
$phar->addFile($sFile, 'test-file-phar');
|
|
$phar->addFromString("test-from-string", 'test-file-phar');
|
|
$phar->extractTo(__DIR__);
|
|
var_dump(decoct(stat(__DIR__ . '/test-file-phar')['mode']));
|
|
var_dump(decoct(stat(__DIR__ . '/test-from-string')['mode']));
|
|
unlink(__DIR__ . '/test-file-phar');
|
|
unlink(__DIR__ . '/test-from-string');
|
|
unlink(__DIR__ . '/test77022.' . $ext);
|
|
}
|
|
unlink($sFile);
|
|
?>
|
|
--EXPECT--
|
|
string(2) "22"
|
|
string(6) "100600"
|
|
string(6) "100600"
|
|
string(6) "100644"
|
|
string(6) "100600"
|
|
string(6) "100644"
|