mirror of
https://github.com/php/php-src.git
synced 2026-04-28 10:43:30 +02:00
Calvin Buckley
5a2b251610
Like oci8, procedural ODBC uses an apply function on the hash list to enumerate persistent connections and close the specific one. However, this function take zvals, not resources. However, it was getting casted as such, causing it to interpret the pointer incorrectly. This could have caused other issues, but mostly manifested as failing to close the connection even fi it matched. The function now takes a zval and gets the resource from that. In addition, it also removes the cast of the function pointer and moves casting to the function body, to avoid possible confusion like this in refactors again. It also cleans up style and uses constants in the function body. Closes GH-12132 Signed-off-by: George Peter Banyard <girgias@php.net>
66 lines
1.7 KiB
PHP
66 lines
1.7 KiB
PHP
--TEST--
|
|
odbc_pconnect(): Make sure closing a persistent connection works
|
|
--EXTENSIONS--
|
|
odbc
|
|
--SKIPIF--
|
|
<?php
|
|
|
|
include 'skipif.inc';
|
|
|
|
// The test can affect multiple drivers, but testing it is driver-specific.
|
|
// Since CI runs ODBC tests with SQL Server, just use an SQL Server specific way of testing.
|
|
$conn = odbc_connect($dsn, $user, $pass);
|
|
$result = @odbc_exec($conn, "SELECT @@Version");
|
|
if ($result) {
|
|
$array = odbc_fetch_array($result);
|
|
$info = (string) reset($array);
|
|
if (!str_contains($info, "Microsoft SQL Server")) {
|
|
echo "skip MS SQL specific test";
|
|
}
|
|
}
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
|
|
include 'config.inc';
|
|
|
|
// set a session specific variable via CONTEXT_INFO, if we get the same connection again, it should be identical
|
|
function set_context_info($conn, $string) {
|
|
$hexstring = bin2hex($string);
|
|
return odbc_exec($conn, "SET CONTEXT_INFO 0x$hexstring");
|
|
}
|
|
|
|
function fetch_context_info($conn) {
|
|
$stmt = odbc_exec($conn, "SELECT CONTEXT_INFO() AS CONTEXT_INFO");
|
|
if (!$stmt) {
|
|
return false;
|
|
}
|
|
$res = odbc_fetch_array($stmt);
|
|
if ($res) {
|
|
// this is a binary, so we get a bunch of nulls at the end
|
|
return $res["CONTEXT_INFO"] ? trim($res["CONTEXT_INFO"]) : null;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
// run 1: set expectations
|
|
$conn = odbc_pconnect($dsn, $user, $pass);
|
|
set_context_info($conn, "PHP odbc_pconnect test");
|
|
var_dump(fetch_context_info($conn));
|
|
|
|
// run 2: reuse same connection (imagine this is another request)
|
|
$conn = odbc_pconnect($dsn, $user, $pass);
|
|
var_dump(fetch_context_info($conn));
|
|
|
|
// run 3: close it and see if it's the same connection
|
|
odbc_close($conn);
|
|
$conn = odbc_pconnect($dsn, $user, $pass);
|
|
var_dump(fetch_context_info($conn));
|
|
|
|
?>
|
|
--EXPECT--
|
|
string(22) "PHP odbc_pconnect test"
|
|
string(22) "PHP odbc_pconnect test"
|
|
NULL
|