mirror of
https://github.com/php/php-src.git
synced 2026-04-21 15:08:16 +02:00
Nikita Popov
b10416a652
This deprecates passing null to non-nullable scale arguments of internal functions, with the eventual goal of making the behavior consistent with userland functions, where null is never accepted for non-nullable arguments. This change is expected to cause quite a lot of fallout. In most cases, calling code should be adjusted to avoid passing null. In some cases, PHP should be adjusted to make some function arguments nullable. I have already fixed a number of functions before landing this, but feel free to file a bug if you encounter a function that doesn't accept null, but probably should. (The rule of thumb for this to be applicable is that the function must have special behavior for 0 or "", which is distinct from the natural behavior of the parameter.) RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg Closes GH-6475.
37 lines
1013 B
PHP
37 lines
1013 B
PHP
--TEST--
|
|
Bug #39504 (xmlwriter_write_dtd_entity() creates Attlist tag, not enity)
|
|
--SKIPIF--
|
|
<?php
|
|
if (!extension_loaded("xmlwriter")) die("skip");
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
|
|
$xw = xmlwriter_open_memory();
|
|
xmlwriter_start_document($xw, NULL, "UTF-8");
|
|
xmlwriter_start_dtd($xw, "root");
|
|
xmlwriter_write_dtd_entity($xw, "ent2", "val2");
|
|
xmlwriter_end_dtd($xw);
|
|
xmlwriter_start_element($xw, "root");
|
|
xmlwriter_end_document($xw);
|
|
print xmlwriter_flush($xw, true);
|
|
print "\n";
|
|
|
|
$xw = new XMLWriter();
|
|
$xw->openMemory();
|
|
$xw->startDocument(NULL, "UTF-8");
|
|
$xw->startDtd("root");
|
|
$xw->writeDtdEntity("c", "", 0, "-//W3C//TEXT copyright//EN", "http://www.w3.org/xmlspec/copyright.xml");
|
|
$xw->endDtd();
|
|
$xw->startElement("root");
|
|
$xw->endDocument();
|
|
print $xw->flush(true);
|
|
|
|
?>
|
|
--EXPECT--
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
<!DOCTYPE root [<!ENTITY ent2 "val2">]><root/>
|
|
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
<!DOCTYPE root [<!ENTITY c PUBLIC "-//W3C//TEXT copyright//EN" "http://www.w3.org/xmlspec/copyright.xml">]><root/>
|