mirror of
https://github.com/php/php-src.git
synced 2026-04-26 01:18:19 +02:00
Niels Dossche
7c0dfc5cf5
It's possible to categorise the failures into 2 categories:
- Changed error message. In this case we either duplicate the test and
modify the error message. Or if the change in error message is
small, we use the EXPECTF matchers to make the test compatible with both
old and new versions of libxml2.
- Missing warnings. This is caused by a change in libxml2 where the
parser started using SAX APIs internally [1]. In this case the
error_type passed to php_libxml_internal_error_handler() changed from
PHP_LIBXML_ERROR to PHP_LIBXML_CTX_WARNING because it internally
started to use the SAX handlers instead of the generic handlers.
However, for the SAX handlers the current input stack is empty, so
nothing is actually printed. I fixed this by falling back to a
regular warning without a filename & line number reference, which
mimicks the old behaviour. Furthermore, this change now also shows
an additional warning in a test which was previously hidden.
[1] https://gitlab.gnome.org/GNOME/libxml2/-/commit/9a82b94a94bd310db426edd453b0f38c6c8f69f5
Closes GH-11162.
96 lines
2.3 KiB
PHP
96 lines
2.3 KiB
PHP
--TEST--
|
|
Bug #26614 (CDATA sections skipped on line count)
|
|
--EXTENSIONS--
|
|
xml
|
|
--SKIPIF--
|
|
<?php
|
|
if (!defined("LIBXML_VERSION")) die('skip libxml2 test');
|
|
if (LIBXML_VERSION >= 21100) die('skip libxml2 test variant for version < 2.11');
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
/*
|
|
this test works fine with Expat but fails with libxml
|
|
which we now use as default
|
|
|
|
further investigation has shown that not only line count
|
|
is skipped on CDATA sections but that libxml does also
|
|
show different column numbers and byte positions depending
|
|
on context and in opposition to what one would expect to
|
|
see and what good old Expat reported just fine ...
|
|
*/
|
|
|
|
$xmls = array();
|
|
|
|
// Case 1: CDATA Sections
|
|
$xmls["CDATA"] ='<?xml version="1.0" encoding="iso-8859-1" ?>
|
|
<data>
|
|
<![CDATA[
|
|
multi
|
|
line
|
|
CDATA
|
|
block
|
|
]]>
|
|
</data>';
|
|
|
|
// Case 2: replace some characters so that we get comments instead
|
|
$xmls["Comment"] ='<?xml version="1.0" encoding="iso-8859-1" ?>
|
|
<data>
|
|
<!-- ATA[
|
|
multi
|
|
line
|
|
CDATA
|
|
block
|
|
-->
|
|
</data>';
|
|
|
|
// Case 3: replace even more characters so that only textual data is left
|
|
$xmls["Text"] ='<?xml version="1.0" encoding="iso-8859-1" ?>
|
|
<data>
|
|
-!-- ATA[
|
|
multi
|
|
line
|
|
CDATA
|
|
block
|
|
---
|
|
</data>';
|
|
|
|
function startElement($parser, $name, $attrs) {
|
|
printf("<$name> at line %d, col %d (byte %d)\n",
|
|
xml_get_current_line_number($parser),
|
|
xml_get_current_column_number($parser),
|
|
xml_get_current_byte_index($parser));
|
|
}
|
|
|
|
function endElement($parser, $name) {
|
|
printf("</$name> at line %d, col %d (byte %d)\n",
|
|
xml_get_current_line_number($parser),
|
|
xml_get_current_column_number($parser),
|
|
xml_get_current_byte_index($parser));
|
|
}
|
|
|
|
function characterData($parser, $data) {
|
|
// dummy
|
|
}
|
|
|
|
foreach ($xmls as $desc => $xml) {
|
|
echo "$desc\n";
|
|
$xml_parser = xml_parser_create();
|
|
xml_set_element_handler($xml_parser, "startElement", "endElement");
|
|
xml_set_character_data_handler($xml_parser, "characterData");
|
|
if (!xml_parse($xml_parser, $xml, true))
|
|
echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
|
|
xml_parser_free($xml_parser);
|
|
}
|
|
?>
|
|
--EXPECTF--
|
|
CDATA
|
|
<DATA> at line 2, col %d (byte 9)
|
|
</DATA> at line 9, col %d (byte 55)
|
|
Comment
|
|
<DATA> at line 2, col %d (byte 9)
|
|
</DATA> at line 9, col %d (byte 55)
|
|
Text
|
|
<DATA> at line 2, col %d (byte 9)
|
|
</DATA> at line 9, col %d (byte 55)
|