mirror of
https://github.com/php/php-src.git
synced 2026-03-27 17:52:16 +01:00
80598f1250
Aside from a few very specific syntax errors for which detailed exceptions are
thrown, generally PHP just emits the default error messages generated by bison on syntax
error. These messages are very uninformative; they just say "Unexpected ... at line ...".
This is most problematic with constructs which can span an arbitrary number of lines, such
as blocks of code delimited by { }, 'if' conditions delimited by ( ), and so on. If a closing
delimiter is missed, the block will run for the entire remainder of the source file (which
could be thousands of lines), and then at the end, a parse error will be thrown with the
dreaded words: "Unexpected end of file".
Therefore, track the positions of opening and closing delimiters and ensure that they match
up correctly. If any mismatch or missing delimiter is detected, immediately throw a parse
error which points the user to the offending line. This is best done in the *lexer* and not
in the parser.
Thanks to Nikita Popov and George Peter Banyard for suggesting improvements.
Fixes bug #79368.
Closes GH-5364.
52 lines
975 B
PHP
52 lines
975 B
PHP
--TEST--
|
|
Parse exceptions when using require
|
|
--INI--
|
|
allow_url_include=1
|
|
--FILE--
|
|
<?php
|
|
|
|
function test_parse_error($code) {
|
|
try {
|
|
require 'data://text/plain;base64,' . base64_encode($code);
|
|
} catch (ParseError $e) {
|
|
echo $e->getMessage(), " on line ", $e->getLine(), "\n";
|
|
}
|
|
}
|
|
|
|
test_parse_error(<<<'EOC'
|
|
<?php
|
|
{ { { { { }
|
|
EOC
|
|
);
|
|
|
|
test_parse_error(<<<'EOC'
|
|
<?php
|
|
/** doc comment */
|
|
function f() {
|
|
EOC
|
|
);
|
|
|
|
test_parse_error(<<<'EOC'
|
|
<?php
|
|
empty
|
|
EOC
|
|
);
|
|
|
|
test_parse_error('<?php
|
|
var_dump(078);');
|
|
|
|
test_parse_error('<?php
|
|
var_dump("\u{xyz}");');
|
|
test_parse_error('<?php
|
|
var_dump("\u{ffffff}");');
|
|
|
|
?>
|
|
--EXPECT--
|
|
Deprecated: Directive 'allow_url_include' is deprecated in Unknown on line 0
|
|
Unclosed '{' on line 2
|
|
Unclosed '{' on line 3
|
|
syntax error, unexpected end of file, expecting '(' on line 2
|
|
Invalid numeric literal on line 2
|
|
Invalid UTF-8 codepoint escape sequence on line 2
|
|
Invalid UTF-8 codepoint escape sequence: Codepoint too large on line 2
|