mirror of
https://github.com/php/php-src.git
synced 2026-04-28 18:53:33 +02:00
Michael Orlitzky
bfb0e367f2
Musl has two quirks that are leading to failed internationalization tests. First is that the return value of bindtextdomain(..., NULL) will always be false, rather than an "implementation-defined default directory," because musl does not have an implementation-defined default directory. One test needs a special case for this. Second is that the musl implementation of bind_textdomain_codeset() always returns NULL. The POSIX-correctness of this is debatable, but it is roughly equivalent to correct, because musl only support UTF-8, so the NULL value indicating that the codeset is unchanged from the locale's codeset (UTF-8) is accurate. PHP's bind_textdomain_codeset() function however treats NULL as failure, unconditionally: * https://github.com/php/doc-en/issues/4311 * https://github.com/php/php-src/issues/17163 This unfortunately causes false to be returned consistently on musl -- even when nothing unexpected has happened -- and naturally this is affecting several tests. For now we change two tests to accept "false" in addition to "UTF-8" so that they may pass on musl. If PHP's bind_textdomain_codeset() is updated to differentiate between NULL and NULL-with-errno-set, these tests can also be updated once again to reject the NULL-with-errno result. This partially addresses GH #13696
36 lines
1.1 KiB
PHP
36 lines
1.1 KiB
PHP
--TEST--
|
|
Bug #53251 (bindtextdomain with null dir doesn't return old value)
|
|
--EXTENSIONS--
|
|
gettext
|
|
--SKIPIF--
|
|
<?php
|
|
if (getenv('SKIP_REPEAT')) die('skip gettext leaks global state across requests');
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
$results[] = is_string(bindtextdomain('foo', null));
|
|
$dir = bindtextdomain('foo', '.');
|
|
$results[] = bindtextdomain('foo', null) === $dir;
|
|
$results[] = bind_textdomain_codeset('foo', null);
|
|
$results[] = bind_textdomain_codeset('foo', 'UTF-8');
|
|
$results[] = bind_textdomain_codeset('foo', null);
|
|
|
|
$expected = [true, true, false, "UTF-8", "UTF-8"];
|
|
|
|
// musl's bindtextdomain() has no default directory to return when
|
|
// "foo" is unbound, so in the first call, you will get false instead
|
|
// of a string.
|
|
//
|
|
// bind_textdomain_codeset() always returns false on musl
|
|
// because musl only supports UTF-8. For more information:
|
|
//
|
|
// * https://github.com/php/doc-en/issues/4311,
|
|
// * https://github.com/php/php-src/issues/17163
|
|
//
|
|
$expected_musl = [false, true, false, false, false];
|
|
|
|
var_dump($results === $expected || $results === $expected_musl);
|
|
?>
|
|
--EXPECT--
|
|
bool(true)
|