mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
This is a long standing bug: IDs aren't properly tracked causing either outdated or plain incorrect results from getElementById. This PR implements a pragmatic solution in which we still try to use the ID lookup table to a degree, but only as a performance boost not as a "single source of truth". Full details are explained in the getElementById code. Closes GH-14349.
19 lines
484 B
PHP
19 lines
484 B
PHP
--TEST--
|
|
Bug #79701 (getElementById does not correctly work with duplicate definitions) - attribute node variation
|
|
--EXTENSIONS--
|
|
dom
|
|
--FILE--
|
|
<?php
|
|
$dom = Dom\HTMLDocument::createEmpty();
|
|
$element = $dom->createElement('foo');
|
|
$dom->append($element);
|
|
$attr = $dom->createAttribute('id');
|
|
$attr->value = 'test';
|
|
var_dump($dom->getElementById('test')?->nodeName);
|
|
$element->setAttributeNode($attr);
|
|
var_dump($dom->getElementById('test')?->nodeName);
|
|
?>
|
|
--EXPECT--
|
|
NULL
|
|
string(3) "FOO"
|