mirror of
https://github.com/php/php-src.git
synced 2026-03-31 20:53:00 +02:00
79133df156
* random: Remove `php_random_status`
Since 162e1dce98, the `php_random_status` struct
contains just a single `void*`, resulting in needless indirection when
accessing the engine state and thus decreasing readability because of the
additional non-meaningful `->state` references / the local helper variables.
There is also a small, but measurable performance benefit:
<?php
$e = new Random\Engine\Xoshiro256StarStar(0);
$r = new Random\Randomizer($e);
for ($i = 0; $i < 15; $i++)
var_dump(strlen($r->getBytes(100000000)));
goes from roughly 3.85s down to 3.60s.
The names of the `status` variables have not yet been touched to keep the diff
small. They will be renamed to the more appropriate `state` in a follow-up
cleanup commit.
* Introduce `php_random_algo_with_state`
57 lines
1.6 KiB
C
57 lines
1.6 KiB
C
/*
|
|
+----------------------------------------------------------------------+
|
|
| Copyright (c) The PHP Group |
|
|
+----------------------------------------------------------------------+
|
|
| This source file is subject to version 3.01 of the PHP license, |
|
|
| that is bundled with this package in the file LICENSE, and is |
|
|
| available through the world-wide-web at the following url: |
|
|
| https://www.php.net/license/3_01.txt |
|
|
| If you did not receive a copy of the PHP license and are unable to |
|
|
| obtain it through the world-wide-web, please send a note to |
|
|
| license@php.net so we can mail you a copy immediately. |
|
|
+----------------------------------------------------------------------+
|
|
| Authors: Sammy Kaye Powers <me@sammyk.me> |
|
|
| Go Kudo <zeriyoshi@php.net> |
|
|
+----------------------------------------------------------------------+
|
|
*/
|
|
|
|
#ifdef HAVE_CONFIG_H
|
|
# include "config.h"
|
|
#endif
|
|
|
|
#include "php.h"
|
|
#include "php_random.h"
|
|
#include "php_random_csprng.h"
|
|
|
|
#include "Zend/zend_exceptions.h"
|
|
|
|
static php_random_result generate(void *status)
|
|
{
|
|
zend_ulong r = 0;
|
|
|
|
php_random_bytes_throw(&r, sizeof(r));
|
|
|
|
return (php_random_result){
|
|
.size = sizeof(zend_ulong),
|
|
.result = r,
|
|
};
|
|
}
|
|
|
|
static zend_long range(void *status, zend_long min, zend_long max)
|
|
{
|
|
zend_long result = 0;
|
|
|
|
php_random_int_throw(min, max, &result);
|
|
|
|
return result;
|
|
}
|
|
|
|
const php_random_algo php_random_algo_secure = {
|
|
0,
|
|
NULL,
|
|
generate,
|
|
range,
|
|
NULL,
|
|
NULL
|
|
};
|