mirror of
https://github.com/php/php-src.git
synced 2026-04-18 13:31:27 +02:00
b10416a652
This deprecates passing null to non-nullable scale arguments of internal functions, with the eventual goal of making the behavior consistent with userland functions, where null is never accepted for non-nullable arguments. This change is expected to cause quite a lot of fallout. In most cases, calling code should be adjusted to avoid passing null. In some cases, PHP should be adjusted to make some function arguments nullable. I have already fixed a number of functions before landing this, but feel free to file a bug if you encounter a function that doesn't accept null, but probably should. (The rule of thumb for this to be applicable is that the function must have special behavior for 0 or "", which is distinct from the natural behavior of the parameter.) RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg Closes GH-6475.
26 lines
716 B
PHP
26 lines
716 B
PHP
--TEST--
|
|
Bug #69111 Crash in SessionHandler::read()
|
|
--SKIPIF--
|
|
<?php include('skipif.inc'); ?>
|
|
--FILE--
|
|
<?php
|
|
$sh = new SessionHandler;
|
|
session_set_save_handler($sh);
|
|
|
|
$savePath = ini_get('session.save_path');
|
|
$sessionName = ini_get('session.name');
|
|
|
|
// session_start(); // Uncommenting this makes it not crash when reading the session (see below), but it will not return any data.
|
|
|
|
$sh->open($savePath, $sessionName);
|
|
$sh->write("foo", "bar");
|
|
var_dump($sh->read(""));
|
|
?>
|
|
--EXPECTF--
|
|
Warning: SessionHandler::open(): Session is not active in %s on line 10
|
|
|
|
Warning: SessionHandler::write(): Session is not active in %s on line 11
|
|
|
|
Warning: SessionHandler::read(): Session is not active in %s on line 12
|
|
bool(false)
|