mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
35 lines
795 B
PHP
35 lines
795 B
PHP
--TEST--
|
|
IntlTimeZone::getErrorCode/Message(): basic test
|
|
--EXTENSIONS--
|
|
intl
|
|
--SKIPIF--
|
|
<?php
|
|
/* INF being an invalid offset depends on UB in float->int cast behavior. */
|
|
$arch = php_uname('m');
|
|
if ($arch != 'x86_64' && $arch != 'i386')
|
|
die('skip requires x86');
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
ini_set("intl.error_level", E_WARNING);
|
|
|
|
$lsb = IntlTimeZone::createTimeZone('Europe/Lisbon');
|
|
|
|
var_dump($lsb->getErrorCode());
|
|
var_dump($lsb->getErrorMessage());
|
|
|
|
var_dump($lsb->getOffset(INF, 1, $a, $b));
|
|
|
|
var_dump($lsb->getErrorCode());
|
|
var_dump($lsb->getErrorMessage());
|
|
|
|
?>
|
|
--EXPECTF--
|
|
int(0)
|
|
string(12) "U_ZERO_ERROR"
|
|
|
|
Warning: IntlTimeZone::getOffset(): error obtaining offset in %s on line %d
|
|
bool(false)
|
|
int(1)
|
|
string(75) "IntlTimeZone::getOffset(): error obtaining offset: U_ILLEGAL_ARGUMENT_ERROR"
|