mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
18 lines
445 B
PHP
18 lines
445 B
PHP
--TEST--
|
|
IntlTimeZone::fromDateTimeZone(): argument errors
|
|
--INI--
|
|
date.timezone=Atlantic/Azores
|
|
--EXTENSIONS--
|
|
intl
|
|
--FILE--
|
|
<?php
|
|
|
|
$dt = new DateTime('2012-08-01 00:00:00 WEST');
|
|
var_dump(IntlTimeZone::fromDateTimeZone($dt->getTimeZone()));
|
|
var_dump(intl_get_error_message());
|
|
|
|
?>
|
|
--EXPECT--
|
|
NULL
|
|
string(131) "IntlTimeZone::fromDateTimeZone(): time zone id 'WEST' extracted from ext/date DateTimeZone not recognized: U_ILLEGAL_ARGUMENT_ERROR"
|