mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
6600d0e00f
This is a comprehensive refactoring of the error mechanism of the Intl extension. By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits: - Accurate error messages indicating *what* call caused the error - As we *always* "copy" the message, the `copyMsg` arg becomes unused, meaning we can reduce the size of the `intl_error` struct by 4 bytes. - Saving it as a zend_string means we know the length of the message - Remove the need to pass around a "function name" `char*` across multiple calls - Use Intl's exception mechanism to generate exceptions for constructor call - This removes the need for replacing the error handler - Which didn't do anything anyway in silent mode, which required throwing non-descriptive exceptions
29 lines
810 B
PHP
29 lines
810 B
PHP
--TEST--
|
|
Bug #53512 (NumberFormatter::setSymbol crash on bogus $attr values)
|
|
--EXTENSIONS--
|
|
intl
|
|
--SKIPIF--
|
|
<?php if (PHP_INT_SIZE != 8) die('skip 64-bit only');
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
|
|
$badvals = array(4294901761, 2147483648, -2147483648, -1);
|
|
|
|
foreach ($badvals as $val) {
|
|
$x = numfmt_create("en", NumberFormatter::PATTERN_DECIMAL);
|
|
var_dump(numfmt_set_symbol($x, $val, ""));
|
|
var_dump(intl_get_error_message());
|
|
}
|
|
|
|
?>
|
|
--EXPECT--
|
|
bool(false)
|
|
string(67) "numfmt_set_symbol(): invalid symbol value: U_ILLEGAL_ARGUMENT_ERROR"
|
|
bool(false)
|
|
string(67) "numfmt_set_symbol(): invalid symbol value: U_ILLEGAL_ARGUMENT_ERROR"
|
|
bool(false)
|
|
string(67) "numfmt_set_symbol(): invalid symbol value: U_ILLEGAL_ARGUMENT_ERROR"
|
|
bool(false)
|
|
string(67) "numfmt_set_symbol(): invalid symbol value: U_ILLEGAL_ARGUMENT_ERROR"
|