mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
6173a9a109
The aim of this PR is twofold:
- Reduce the number of highly similar TMP|VAR handlers
- Avoid ZVAL_DEREF in most of these cases
This is achieved by guaranteeing that all zend_compile_expr() calls, as well as
all other compile calls with BP_VAR_{R,IS}, will result in a TMP variable. This
implies that the result will not contain an IS_INDIRECT or IS_REFERENCE value,
which was mostly already the case, with two exceptions:
- Calls to return-by-reference functions. Because return-by-reference functions
are quite rare, this is solved by delegating the DEREF to the RETURN_BY_REF
handler, which will examine the stack to check whether the caller expects a
VAR or TMP to understand whether the DEREF is needed. Internal functions will
also need to adjust by calling the zend_return_unwrap_ref() function.
- By-reference assignments, including both $a = &$b, as well as $a = [&$b]. When
the result of these expressions is used in a BP_VAR_R context, the reference
is unwrapped via a ZEND_QM_ASSIGN opcode beforehand. This is exceptionally
rare.
Closes GH-20628
56 lines
1.0 KiB
PHP
56 lines
1.0 KiB
PHP
--TEST--
|
|
SCCP 032: Yield from optimizations
|
|
--INI--
|
|
opcache.enable=1
|
|
opcache.enable_cli=1
|
|
opcache.optimization_level=-1
|
|
opcache.opt_debug_level=0x20000
|
|
opcache.preload=
|
|
zend_test.observer.enabled=0
|
|
--EXTENSIONS--
|
|
opcache
|
|
--FILE--
|
|
<?php
|
|
function test(): Generator {
|
|
$result = yield from [];
|
|
$a = [];
|
|
yield from $a;
|
|
yield $result;
|
|
$a[] = 3;
|
|
yield from $a;
|
|
}
|
|
foreach (test() as $x) {
|
|
var_export($x);
|
|
echo "\n";
|
|
}
|
|
?>
|
|
--EXPECTF--
|
|
$_main:
|
|
; (lines=11, args=0, vars=1, tmps=2)
|
|
; (after optimizer)
|
|
; %ssccp_032.php:1-15
|
|
0000 INIT_FCALL 0 %d string("test")
|
|
0001 T2 = DO_UCALL
|
|
0002 T1 = FE_RESET_R T2 0009
|
|
0003 FE_FETCH_R T1 CV0($x) 0009
|
|
0004 INIT_FCALL 1 %d string("var_export")
|
|
0005 SEND_VAR CV0($x) 1
|
|
0006 DO_ICALL
|
|
0007 ECHO string("\n")
|
|
0008 JMP 0003
|
|
0009 FE_FREE T1
|
|
0010 RETURN int(1)
|
|
LIVE RANGES:
|
|
1: 0003 - 0009 (loop)
|
|
|
|
test:
|
|
; (lines=4, args=0, vars=0, tmps=0)
|
|
; (after optimizer)
|
|
; %ssccp_032.php:2-9
|
|
0000 GENERATOR_CREATE
|
|
0001 YIELD null
|
|
0002 YIELD_FROM array(...)
|
|
0003 GENERATOR_RETURN null
|
|
NULL
|
|
3
|