mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
6173a9a109
The aim of this PR is twofold:
- Reduce the number of highly similar TMP|VAR handlers
- Avoid ZVAL_DEREF in most of these cases
This is achieved by guaranteeing that all zend_compile_expr() calls, as well as
all other compile calls with BP_VAR_{R,IS}, will result in a TMP variable. This
implies that the result will not contain an IS_INDIRECT or IS_REFERENCE value,
which was mostly already the case, with two exceptions:
- Calls to return-by-reference functions. Because return-by-reference functions
are quite rare, this is solved by delegating the DEREF to the RETURN_BY_REF
handler, which will examine the stack to check whether the caller expects a
VAR or TMP to understand whether the DEREF is needed. Internal functions will
also need to adjust by calling the zend_return_unwrap_ref() function.
- By-reference assignments, including both $a = &$b, as well as $a = [&$b]. When
the result of these expressions is used in a BP_VAR_R context, the reference
is unwrapped via a ZEND_QM_ASSIGN opcode beforehand. This is exceptionally
rare.
Closes GH-20628
48 lines
904 B
PHP
48 lines
904 B
PHP
--TEST--
|
|
DCE 006: Objects with destructors escape
|
|
--INI--
|
|
opcache.enable=1
|
|
opcache.enable_cli=1
|
|
opcache.optimization_level=-1
|
|
opcache.opt_debug_level=0x20000
|
|
opcache.preload=
|
|
zend_test.observer.enabled=0
|
|
--EXTENSIONS--
|
|
opcache
|
|
--FILE--
|
|
<?php
|
|
class A {
|
|
function __destruct() {}
|
|
}
|
|
function foo(int $x) {
|
|
$a = new A;
|
|
$a->foo = $x;
|
|
}
|
|
?>
|
|
--EXPECTF--
|
|
$_main:
|
|
; (lines=1, args=0, vars=0, tmps=0)
|
|
; (after optimizer)
|
|
; %sdce_006.php:1-10
|
|
0000 RETURN int(1)
|
|
|
|
foo:
|
|
; (lines=7, args=1, vars=2, tmps=1)
|
|
; (after optimizer)
|
|
; %sdce_006.php:5-8
|
|
0000 CV0($x) = RECV 1
|
|
0001 T2 = NEW 0 string("A")
|
|
0002 DO_FCALL
|
|
0003 CV1($a) = QM_ASSIGN T2
|
|
0004 ASSIGN_OBJ CV1($a) string("foo")
|
|
0005 OP_DATA CV0($x)
|
|
0006 RETURN null
|
|
LIVE RANGES:
|
|
2: 0002 - 0003 (new)
|
|
|
|
A::__destruct:
|
|
; (lines=1, args=0, vars=0, tmps=0)
|
|
; (after optimizer)
|
|
; %sdce_006.php:3-3
|
|
0000 RETURN null
|