Alex Dowad d44235acae
Convert numeric string array keys to integers correctly in JITted code ...
While fixing bugs in mbstring, one of my new test cases failed with a strange
error message stating: 'Warning: Undefined array key 1...', when clearly the
array key had been set properly.
GDB'd that sucker and found that JIT'd PHP code was calling directly into
`zend_hash_add_new` (which was not converting the numeric string key to an
integer properly). But where was that code coming from? I examined the disasm,
looked up symbols to figure out where call instructions were going, then grepped
the codebase for those function names. It soon became clear that the disasm I
was looking at was compiled from `zend_jit_fetch_dim_w_helper`.
2020-10-30 22:07:08 +02:00
2020-10-21 17:06:48 +02:00
2020-10-16 10:56:33 +02:00
2020-10-07 14:58:43 +02:00
2020-10-26 11:55:29 +01:00
2020-09-01 16:35:56 +02:00
2020-10-14 19:11:58 +02:00
2020-10-26 11:06:10 +01:00
2020-10-22 14:50:52 +02:00
2020-10-26 13:15:03 +01:00
2020-10-02 11:55:46 +02:00
2020-10-02 11:56:16 +02:00
2020-10-30 15:49:48 +01:00
2020-10-26 16:54:30 +01:00
2020-09-29 11:04:09 +02:00
2020-10-02 14:26:39 +02:00
2020-10-22 10:34:14 +02:00
2020-09-30 23:01:56 +02:00
2020-10-15 10:17:55 +02:00
2020-10-07 12:26:46 +02:00
2020-10-09 15:25:23 +02:00
2020-10-23 20:47:35 +01:00
2020-10-16 10:56:33 +02:00
2020-10-24 15:36:05 +02:00
2020-10-15 11:48:47 +02:00
2020-09-03 15:07:03 +02:00
2020-10-26 15:40:12 +01:00
2020-10-29 16:41:09 +01:00
2020-10-29 16:41:09 +01:00
2020-10-16 10:56:33 +02:00
2020-10-29 13:10:32 +01:00
2020-10-30 22:07:08 +02:00
2020-10-20 10:52:50 +02:00
2020-10-22 14:21:22 +02:00
2020-10-22 11:20:02 +02:00
2020-10-28 12:18:17 +01:00
2020-08-01 10:07:05 +02:00
2020-09-25 00:07:57 +02:00
2020-10-29 14:18:04 +01:00
2020-09-14 01:07:58 +02:00
2020-09-28 22:59:51 +02:00
2020-10-13 12:31:39 +02:00
2020-10-12 18:05:35 +02:00
2020-10-20 16:48:12 +02:00
2020-10-14 16:58:07 +02:00
2020-10-06 09:49:40 +02:00
2020-10-22 14:54:43 +02:00
2020-09-30 10:10:28 +02:00
2020-10-30 17:23:18 +01:00
2020-09-30 13:21:17 +02:00
2020-09-30 21:07:25 +02:00
2020-09-18 14:28:32 +02:00
2020-09-18 14:28:32 +02:00
2020-10-08 17:10:52 +02:00
2020-10-08 16:32:01 +02:00
2020-10-06 12:12:43 +02:00
2020-10-13 10:41:35 +02:00
2020-10-26 09:26:18 +01:00
2020-10-06 23:02:18 +02:00
2020-10-30 11:13:35 +01:00
2020-10-01 23:08:20 +02:00
2020-10-01 23:09:31 +02:00
2020-10-01 23:09:56 +02:00
2020-10-22 16:05:57 +02:00
2020-09-29 16:11:08 +02:00
2020-10-09 10:43:35 +02:00
2020-10-08 10:28:50 +02:00
2020-10-16 10:56:33 +02:00
2020-10-08 10:28:50 +02:00
2020-10-30 15:49:48 +01:00
2020-09-29 16:17:23 +02:00
2020-10-16 10:56:33 +02:00
2020-07-06 21:13:34 +02:00
d44235acae