mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
5e9e9c9d51
Commit 5cbe5a538c disabled chunking for all writes to streams. However,
user streams have a callback where code is executed on data that is
subject to the memory limit. Therefore, when using large writes or
stream_copy_to_stream/copy the memory limit can easily be hit with large
enough data.
To solve this, we reintroduce chunking for userspace streams.
Users have control over the chunk size, which is neat because
they can improve the performance by setting the chunk size if
that turns out to be a bottleneck.
In an ideal world, we add an option so we can "ask" the stream whether
it "prefers" chunked writes, similar to how we have
php_stream_mmap_supported & friends. However, that cannot be done on
stable branches.
Closes GH-13136.
40 lines
865 B
PHP
40 lines
865 B
PHP
--TEST--
|
|
User-space streams: set_options returns "not implemented" for unhandled option types
|
|
--FILE--
|
|
<?php
|
|
class test_wrapper {
|
|
public $context;
|
|
function stream_open($path, $mode, $openedpath) {
|
|
return true;
|
|
}
|
|
function stream_eof() {
|
|
return false;
|
|
}
|
|
function stream_write($data) {
|
|
echo "size: ", strlen($data), "\n";
|
|
return strlen($data);
|
|
}
|
|
function stream_set_option($option, $arg1, $arg2) {
|
|
echo "option: ", $option, ", ", $arg1, ", ", $arg2, "\n";
|
|
return false;
|
|
}
|
|
}
|
|
|
|
var_dump(stream_wrapper_register('test', 'test_wrapper'));
|
|
|
|
$fd = fopen("test://foo","r");
|
|
|
|
var_dump(stream_set_write_buffer($fd, 50));
|
|
var_dump(stream_set_chunk_size($fd, 42));
|
|
|
|
var_dump(fwrite($fd, str_repeat('0', 70)));
|
|
?>
|
|
--EXPECT--
|
|
bool(true)
|
|
option: 3, 2, 50
|
|
int(-1)
|
|
int(8192)
|
|
size: 42
|
|
size: 28
|
|
int(70)
|