mirror of
https://github.com/php/php-src.git
synced 2026-04-14 03:22:58 +02:00
This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
23 lines
530 B
PHP
23 lines
530 B
PHP
--TEST--
|
|
Bug #49072 (feof never returns true for damaged file in zip)
|
|
--SKIPIF--
|
|
<?php
|
|
if(!extension_loaded('zip')) die('skip');
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
$f = dirname(__FILE__) . '/bug49072.zip';
|
|
$o = new ZipArchive();
|
|
if (! $o->open($f, ZipArchive::CHECKCONS)) {
|
|
exit ('error can\'t open');
|
|
}
|
|
$r = $o->getStream('file1'); // this file has a wrong crc
|
|
if (!$r)die('failed to open a stream for file1');
|
|
$s = '';
|
|
while (! feof($r)) {
|
|
$s .= fread($r,1024);
|
|
}
|
|
?>
|
|
--EXPECTF--
|
|
Warning: fread(): Zip stream error: CRC error in %s on line %d
|